On OS X system cancel link style looks different against submit button.
Patch attached.

CommentFileSizeAuthor
#11 Before-patch.png477.68 KBdjsagar
#11 After-patch.png117.69 KBdjsagar
#10 2768769-10.patch414 bytesHarish1688
#10 2768769 after patch.png41.96 KBHarish1688
#10 2768769 before patch.png42.18 KBHarish1688
#9 issue-2768769-9.png533.92 KBdjsagar
#7 after-patch.png39.33 KBBhumikaVarshney
#7 before-patch.png42.41 KBBhumikaVarshney
#6 interdiff-2768769-5-6.txt1.16 KBhgoto
#6 adminimal_theme-alternative-skin-cancel-link-2768769-6.patch1.54 KBhgoto
#5 adminimal_theme-alternative-skin-cancel-link-2768769-5.patch1.46 KBhgoto
#4 adminimal_theme-alternative-skin-cancel-link-2768769-4.patch506 bytesiryston
#2 adminimal_theme-properly-display-cancel-link-2768769-1.patch490 bytesiryston
ScreenShot-AT-After.png9.27 KBiryston
ScreenShot-AT-Before.png9.41 KBiryston
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iryston created an issue. See original summary.

iryston’s picture

iryston CreditAttribution: iryston commented
FileSize
adminimal_theme-properly-display-cancel-link-2768769-1.patch490 bytes
iryston’s picture

iryston CreditAttribution: iryston as a volunteer commented
Status: Patch (to be ported) » Needs review
iryston’s picture

iryston CreditAttribution: iryston as a volunteer commented
FileSize
adminimal_theme-alternative-skin-cancel-link-2768769-4.patch506 bytes

Patch for the same bug in the alternative template

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer and at Studio Umi commented
FileSize
adminimal_theme-alternative-skin-cancel-link-2768769-5.patch1.46 KB

I tested the patch #4. This surely fixes the problem.

  position: relative;
  top: 1px;

This code seems to be for aligning submit buttons and cancel links vertically but we don't need to add this if we remove the following lines.

body.mac input[type="submit"]{
  position: relative;
  top: 1px;
}

Is it possible to remove these lines? If so, we can keep the code simpler. I create a patch as a trial. It includes changes for both the default theme and alternative theme.

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer and at Studio Umi commented
FileSize
adminimal_theme-alternative-skin-cancel-link-2768769-6.patch1.54 KB
interdiff-2768769-5-6.txt1.16 KB

I didn't add the prefix body.mac to all of the selector by mistake. I revised the patch #5.

BhumikaVarshney’s picture

BhumikaVarshney CreditAttribution: BhumikaVarshney as a volunteer and at OpenSense Labs commented
FileSize
before-patch.png42.41 KB
after-patch.png39.33 KB

Hi @hgoto
I applied the patch #5. This fixed the problem.
Thanks!

djsagar’s picture

djsagar CreditAttribution: djsagar at OpenSense Labs commented
Version: 7.x-1.24 » 8.x-1.x-dev

There is line height issue in version of 8.x-1.x which can be resolved if we update this
line-height: 1.25em;

line-height:normal;

djsagar’s picture

djsagar CreditAttribution: djsagar at OpenSense Labs commented
FileSize
issue-2768769-9.png533.92 KB
Harish1688’s picture

Harish1688 CreditAttribution: Harish1688 at Srijan | A Material+ Company commented
FileSize
2768769 before patch.png42.18 KB
2768769 after patch.png41.96 KB
2768769-10.patch414 bytes

Hi,

I have tried to reproduced the issue on local with 8.x-1.x-dev and 10.x on OS X system. found the issue their 1px difference from top, but no patch applied. So create a patch (2768769-10.patch) for the issue as per comment #8 suggestion. attached a image for reference.

Tested Steps:
1. Drupal 10 set up and Adminimal theme setup with 8.x-1.x-dev.
2. Moved on path admin/modules/uninstall/confirm, found the issue and applied the all patch but working.
3. Create a new patch, resolved the issue.

Before Patch:
issue image

After Patch:
issue image

djsagar’s picture

djsagar CreditAttribution: djsagar at OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
FileSize
After-patch.png117.69 KB
Before-patch.png477.68 KB

Hi @Harish1688,

Applied patch #10 and it's resolved.

Fix to properly display cancel link on OS X system

Before Patch:
before

After Patch:
after

RTBC ++

Thanks!