So I might be missing something here but I think i've found an issue where in feeds_cron(), the entity query doesn't actually check that the feed is 'active' i.e. enabled, it only checks that the 'next' value != -1.

So you end up having a feed that is 'disabled' (active set to 0) but it will still be picked up on the cron run, then will have items queued up for import, which is not desired!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rossb89 created an issue. See original summary.

rossb89’s picture

rossb89’s picture

Assigned: rossb89 » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: feeds_cron_does_not-2768671-2.patch, failed testing.

rossb89’s picture

Status: Needs work » Needs review
FileSize
354 bytes

My bad, column name is 'status' not 'active.

Updated patch.

twistor’s picture

Looks correct. Trying to get a test in.

The last submitted patch, 6: 2768671-6-test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: 2768671-6.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review
FileSize
1.33 KB
1.68 KB

The last submitted patch, 9: 2768671-9-test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: 2768671-9.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review

The last submitted patch, 12: 2768671-12-test-only.patch, failed testing.

  • twistor committed aac99d3 on 8.x-3.x authored by rossb89
    Issue #2768671 by twistor, rossb89: feeds_cron() does not check if the...
twistor’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.