Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
So I might be missing something here but I think i've found an issue where in feeds_cron()
, the entity query doesn't actually check that the feed is 'active' i.e. enabled, it only checks that the 'next' value != -1.
So you end up having a feed that is 'disabled' (active set to 0) but it will still be picked up on the cron run, then will have items queued up for import, which is not desired!
Comment | File | Size | Author |
---|---|---|---|
#12 | 2768671-12.patch | 1.97 KB | twistor |
| |||
#12 | 2768671-12-test-only.patch | 1.62 KB | twistor |
Comments
Comment #2
rossb89 CreditAttribution: rossb89 at ComputerMinds commentedComment #3
rossb89 CreditAttribution: rossb89 at ComputerMinds commentedComment #5
rossb89 CreditAttribution: rossb89 at ComputerMinds commentedMy bad, column name is 'status' not 'active.
Updated patch.
Comment #6
twistor CreditAttribution: twistor as a volunteer commentedLooks correct. Trying to get a test in.
Comment #9
twistor CreditAttribution: twistor as a volunteer commentedComment #12
twistor CreditAttribution: twistor as a volunteer commentedThis should do it.
Comment #13
twistor CreditAttribution: twistor as a volunteer commentedComment #16
twistor CreditAttribution: twistor as a volunteer commented