It seems that our error checking and reporting in that area could be improved.

CommentFileSizeAuthor
#7 interdiff-2767621-7.txt3.76 KBwoprrr
#7 2767621_3_rerolled.txt3.88 KBwoprrr
#7 provide_better_error-2767621-7.patch3.98 KBwoprrr
#3 interdiff.txt2.99 KBslashrsm
#3 2767621_3.patch3.86 KBslashrsm
#2 2767501_3.patch3.5 KBslashrsm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Active » Needs review
FileSize
2767501_3.patch3.5 KB
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
FileSize
2767621_3.patch3.86 KB
interdiff.txt2.99 KB

BC layer. Not sure if this is the right way to do this.

mErilainen’s picture

mErilainen CreditAttribution: mErilainen at Wunder commented
Status: Needs review » Closed (duplicate)

Isn't this a duplicate of #2767501: Missing thumbnail?

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Closed (duplicate) » Needs review

Not actually. That issue is closed. Patches in there are similar, but we should continue here.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

This needs to type hint on the logger channel factory.

woprrr’s picture

woprrr CreditAttribution: woprrr at NeoLynk commented
Status: Needs work » Needs review
FileSize
provide_better_error-2767621-7.patch3.98 KB
2767621_3_rerolled.txt3.88 KB
interdiff-2767621-7.txt3.76 KB

This is a re-rooll ++ usage of correct logger factory. I think all's okay.