Reference link for adding composer.json file -

https://www.drupal.org/node/2514612
https://www.drupal.org/node/2404989

CommentFileSizeAuthor
#7 interdiff.txt2.26 KBpfrenssen
#7 2767513-7.patch1.28 KBpfrenssen
#3 2767513-3.patch1.3 KBaks22
composer-file.patch1.33 KBaks22
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aks22 created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Needs work

now this file is optional but still makes sense to have, patch just needs clean-up

  1. +++ b/composer.json
@@ -0,0 +1,34 @@
+  "minimum-stability": "dev",  ¶
...
+	{
...
+	{
...
+	{

    please replace tabs with spaces and remove trailing whitespace 

  2. +++ b/composer.json
@@ -0,0 +1,34 @@
\ No newline at end of file

    add new line

aks22’s picture

aks22 CreditAttribution: aks22 as a volunteer and at Cybage Software Pvt Ltd. commented
Status: Needs work » Needs review
FileSize
2767513-3.patch1.3 KB

Please find attached file as per your suggestions. Hope i have created the new patch as per the issues raised.
Please let me know if anything is wrong in this patch, I tried for interdiff, but i couldn't get it by following this https://www.drupal.org/documentation/git/interdiff.

Thanks.

Status: Needs review » Needs work

The last submitted patch, 3: 2767513-3.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented

@aks22, 

+++ b/composer.json
@@ -0,0 +1,33 @@
+  "minimum-stability": "dev",  ¶

Patch still contains a whitespace.

Other than that, patch looks OK.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen as a volunteer and at European Commission and European Union Institutions, Agencies and Bodies commented 
  1. +++ b/composer.json
@@ -0,0 +1,33 @@
+    }
+  {

    Missing comma after this object. 

  2. +++ b/composer.json
@@ -0,0 +1,33 @@
+  {
+    "name": "Andrey Postnikov (andypost)",
+    "homepage": "https://www.drupal.org/u/andypost",
+    "role": "Maintainer"
+    }

    This is not correctly indented. Also missing comma. The next two objects also have this problem. 

  3. +++ b/composer.json
@@ -0,0 +1,33 @@
+  },

    Closing curly brace is missing.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen as a volunteer and at European Commission and European Union Institutions, Agencies and Bodies commented
Category: Bug report » Task
Status: Needs work » Needs review
FileSize
2767513-7.patch1.28 KB
interdiff.txt2.26 KB

Fixed the formatting. Indented to 4 spaces as is the common standard in json files. I also think this is a task rather than a bug.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Assigned: aks22 » Unassigned
Status: Needs review » Reviewed & tested by the community

lgtm

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Reviewed & tested by the community » Fixed

Thanx for your contribution

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.