Fix autostart [#2767145]

Problem/Motivation

The API of jw player (https://developer.jwplayer.com/jw-player/docs/developer-guide/customizat...) uses autostart for start a video when loading the page, the feature is not working due the wording change in the module which uses autoplay.

Proposed resolution

Fix it.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#7	interdiff-2767145-6-7.txt	408 bytes	johnchque
#7	fix_autostart-2767145-7.patch	6.66 KB	johnchque
#7	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 Patch failed to apply
#6	interdiff-2767145-3-6.txt	734 bytes	johnchque
#6	fix_autostart-2767145-6.patch	6.62 KB	johnchque
#6	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 7 pass
#3	fix_autostart-2767145-3.patch	6.63 KB	johnchque
#3	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 7 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 July 2016 at 15:38

yongt9412 created an issue. See original summary.

Comment #2

johnchque

Spanish

Bolivia

CreditAttribution: johnchque at MD Systems GmbH commented 15 July 2016 at 15:38

Issue summary:

View changes

Comment #3

johnchque

Spanish

Bolivia

CreditAttribution: johnchque at MD Systems GmbH commented 25 July 2016 at 07:42

File	Size
fix_autostart-2767145-3.patch	6.63 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 7 pass

Added fix. Not really sure if the update function is needed but it was added anyway.

Comment #4

johnchque

Spanish

Bolivia

CreditAttribution: johnchque at MD Systems GmbH commented 25 July 2016 at 07:42

Status:

Active

» Needs review

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 25 July 2016 at 08:00

Status:

Needs review

» Needs work

+++ b/jw_player.install
@@ -61,3 +64,17 @@ function jw_player_update_8002() {
+    if ($preset->getSetting('autoplay')) {

this only migrates the setting if it was enabled, otherwise it leaves the old key. Instead call getSettings() and do a isset() on $settings and migrate both TRUE and FALSE.