Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
DESCRIPTION
I was thinking of reopening the #1903694: "Add files" button ignores translation issue but this is something somewhat different.
In version 2.1.9 of the Plupload library, they have changed the "Add files" text of the action button to "Add Files" with a capital "F". As a result, this module's js/i18n.js file doesn't provide a proper translation for the "Add Files" text.
PROPOSAL
Just add a line to translate "Add Files". This way both versions of the Plupload library will be handled properly.
Comment | File | Size | Author |
---|---|---|---|
#4 | plupload-multiple_translation_strings_changed-2766275-3.patch | 4.52 KB | budalokko |
#2 | plupload-multiple_translation_strings_changed-2766275-2.patch | 3.27 KB | budalokko |
Comments
Comment #2
budalokko CreditAttribution: budalokko commented"Add files" is not the only string that has changed on Plupload library between 1.5.8 and 2.1.9 versions. There have been multiple changes, additions and removals. We could try to solve all the changes in this issue, so I updated issue title accordingly.
Plupload module 7.x.-2.x currently needs 2.1.9 library version and won't work with older 1.5.x versions, so I think better forget old string translations, specially with the numerous changes.
Attached a patch which makes translations work again.
Only applying the patch won't make translations appear directly.
In order to test it, you can:
- Clear cache
- Visit a form with a plupload widget on it, for example http://sitename/plupload-test
- Add some translations at Administration > Configuration > Regional and language > Translate interface
Comment #3
budalokko CreditAttribution: budalokko commentedComment #4
budalokko CreditAttribution: budalokko commentedPlupload v2.1.9 already contain some translation files in js/i18n/.
Attached patch is more or less equivalent to previous one but strings are ordered as in libraries js/i18n/en.js so it will be easier to update in future plupload releases.
Comment #6
budalokko CreditAttribution: budalokko commented