Right now the Google Map specific settings like map type, width, height etc are added directly to the parent form. This bloats up the forms and distracts from what's important. Move the google map settings to a fieldset instead.

CommentFileSizeAuthor
#2 2766131-2-move-google-settings-to-fieldset.patch11.82 KBChristianAdamski
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ChristianAdamski created an issue. See original summary.

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented
FileSize
2766131-2-move-google-settings-to-fieldset.patch11.82 KB

Here's a patch.

ATTENTION: you need to reset the map settings after applying this patch.

This is acceptable, as the current settings form is only available in -dev for three weeks or so.

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented
Status: Active » Needs review
ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented
Status: Needs review » Fixed

  • ChristianAdamski authored da19fe7 on 8.x-1.x 
    Issue #2766131 by ChristianAdamski: Move Google Map settings to fieldset
shanegarnett’s picture

shanegarnett CreditAttribution: shanegarnett as a volunteer and commented

Found an error when troubleshooting this :
Line 176 of geolocation.js needs to be changed from

map.settings = $.extend(Drupal.geolocation.defaultSettings(), map.settings);

to

map.settings.google_map_settings = $.extend(Drupal.geolocation.defaultSettings(), map.settings);

Was getting a javascript error otherwise.

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented
Status: Fixed » Active
ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented

Could you resave your view settings and try again? Is this still happening?

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented
Status: Active » Postponed (maintainer needs more info)
ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented

Setting this back to fixed. JS issue will be handled in #2768813: Geocoder Widget: "Cannot read property 'height' of undefined"

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented
Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.