Fix tests and 'drush' installation with Drupal 7.50 and greater

Committed!

Updating to 7.50 breaks the tests:

The following module is missing from the file system: panopoly_demo. [error]
In order to fix this, put the module back in its original location.
For more information, see the documentation page. in
_drupal_trigger_error_with_delayed_logging() (line 1128 of
/home/travis/build/panopoly/drupal-7/drupal/includes/bootstrap.inc).
The following module is missing from the file system: panopoly_news. [error]
In order to fix this, put the module back in its original location.
For more information, see the documentation page. in
_drupal_trigger_error_with_delayed_logging() (line 1128 of
/home/travis/build/panopoly/drupal-7/drupal/includes/bootstrap.inc).
The following module is missing from the file system: panopoly_faq.  [error]
In order to fix this, put the module back in its original location.
For more information, see the documentation page. in
_drupal_trigger_error_with_delayed_logging() (line 1128 of
/home/travis/build/panopoly/drupal-7/drupal/includes/bootstrap.inc).

Installation exits with a non-zero error code so it errors out, although, it does seem as though it actually succeeded in installing!

See https://travis-ci.org/panopoly/panopoly/jobs/144435388

Here's the patch.

@humansky: Since this isn't a security update (just bug fixes and features) and I don't have a client who needs 7.50, this is really a low priority for me. As far as I know, the warnings don't actually hurt anything in a running site, but they do break our tests and we can't have broken tests because it could hide other problems. As far as whether you need to rollback, that really depends on testing of your application - if you don't see any issues, it could be fine? That said, we still haven't been able to run the Panopoly test suite because of these problems.

Thanks, your apps patch looks good! If you can make a patch to panopoly_core.make that adds that patch to panopoly I'll kick off a test build. :-) Otherwise, I'll get around to setting that up myself when I have time.

Here's another issue that might be related:

#2765117: Profiles directory distros, and "The following module is missing from the file system..." warnings

Since Drupal 7.52 is a security update, I'm going to push this forward (in #2828241: Upgrade to Drupal 7.52) even though it breaks the tests and installation via Drush. Re-working this issue to be about fixing those issues, since the upgrade is going forward anyway.

Replaced issue summary with info from comment #5

Here's a new patch to test the apps patch

Gah, stupid type-o

Hrm. The patch reduces the number of errors down to just 1:

The following module is missing from the file system: panopoly_demo. [error]
For information about how to fix this, see the documentation page. in
_drupal_trigger_error_with_delayed_logging() (line 1128 of
/home/travis/build/panopoly/drupal-7/drupal/includes/bootstrap.inc).
Updates downloaded successfully.                                     [status]
WD php: User warning: The following module is missing from the file  [warning]
system: panopoly_demo. For information about how to fix this, see the
documentation page. in _drupal_trigger_error_with_delayed_logging()
(line 1128 of
/home/travis/build/panopoly/drupal-7/drupal/includes/bootstrap.inc).

But we're still getting the error for panopoly_demo. Maybe the difference is that we actually attempt to enable it during installation?

Here's the most important part of a stack trace of this issue:

#0  _drupal_get_filename_fallback(module, panopoly_demo, 1, ) called at [/var/www/panopoly-7.x/includes/bootstrap.inc:891]
#1  drupal_get_filename(module, panopoly_demo) called at [/var/www/panopoly-7.x/includes/common.inc:2882]
#2  drupal_get_path(module, panopoly_demo) called at [/var/www/panopoly-7.x/includes/module.inc:339]
#3  module_load_include(inc, panopoly_demo, panopoly_demo.search_api) called at [/var/www/panopoly-7.x/includes/module.inc:688]
#4  module_hook(panopoly_demo, search_api_item_type_info) called at [/var/www/panopoly-7.x/profiles/panopoly/modules/contrib/search_api/search_api.module:791]
#5  search_api_system_info_alter(Array ([name] => Panopoly Demo,[description] => Demo functionality and content to help show the power of Panopoly,[core] => 7.x,[package] => Panopoly Demos,[project] => panopoly_demo,[dependencies] => Array ([0] => features,[1] => migrate,[2] => page_manager,[3] => panopoly_pages,[4] => views,[5] => views_content),[stylesheets] => Array ([all] => Array ([panopoly_demo.css] => sites/all/modules/panopoly_demo/panopoly_demo.css)),[features] => Array ([ctools] => Array ([0] => page_manager:pages_default:1,[1] => views:views_default:3.0),[features_api] => Array ([0] => api:2),[page_manager_pages] => Array ([0] => panopoly_demo_panel),[views_view] => Array ([0] => panopoly_demo)),[files] => Array ([0] => import/panopoly_demo.node.inc,[1] => import/panopoly_demo.menu.inc),[version] => 7.x-1.41+0-dev,[datestamp] => 1479408721,[mtime] => 1482250581,[php] => 5.2.4,[bootstrap] => 0), stdClass Object ([uri] => sites/all/modules/panopoly_demo/panopoly_demo.module,[filename] => sites/all/modules/panopoly_demo/panopoly_demo.module,[name] => panopoly_demo,[info] => Array ([name] => Panopoly Demo,[description] => Demo functionality and content to help show the power of Panopoly,[core] => 7.x,[package] => Panopoly Demos,[project] => panopoly_demo,[dependencies] => Array ([0] => features,[1] => migrate,[2] => page_manager,[3] => panopoly_pages,[4] => views,[5] => views_content),[stylesheets] => Array ([all] => Array ([panopoly_demo.css] => sites/all/modules/panopoly_demo/panopoly_demo.css)),[features] => Array ([ctools] => Array ([0] => page_manager:pages_default:1,[1] => views:views_default:3.0),[features_api] => Array ([0] => api:2),[page_manager_pages] => Array ([0] => panopoly_demo_panel),[views_view] => Array ([0] => panopoly_demo)),[files] => Array ([0] => import/panopoly_demo.node.inc,[1] => import/panopoly_demo.menu.inc),[version] => 7.x-1.41+0-dev,[datestamp] => 1479408721,[mtime] => 1482250581,[php] => 5.2.4,[bootstrap] => 0)), module, ) called at [/var/www/panopoly-7.x/includes/module.inc:1163]
#6  drupal_alter(system_info, Array ([name] => Panopoly Demo,[description] => Demo functionality and content to help show the power of Panopoly,[core] => 7.x,[package] => Panopoly Demos,[project] => panopoly_demo,[dependencies] => Array ([0] => features,[1] => migrate,[2] => page_manager,[3] => panopoly_pages,[4] => views,[5] => views_content),[stylesheets] => Array ([all] => Array ([panopoly_demo.css] => sites/all/modules/panopoly_demo/panopoly_demo.css)),[features] => Array ([ctools] => Array ([0] => page_manager:pages_default:1,[1] => views:views_default:3.0),[features_api] => Array ([0] => api:2),[page_manager_pages] => Array ([0] => panopoly_demo_panel),[views_view] => Array ([0] => panopoly_demo)),[files] => Array ([0] => import/panopoly_demo.node.inc,[1] => import/panopoly_demo.menu.inc),[version] => 7.x-1.41+0-dev,[datestamp] => 1479408721,[mtime] => 1482250581,[php] => 5.2.4,[bootstrap] => 0), stdClass Object ([uri] => sites/all/modules/panopoly_demo/panopoly_demo.module,[filename] => sites/all/modules/panopoly_demo/panopoly_demo.module,[name] => panopoly_demo,[info] => Array ([name] => Panopoly Demo,[description] => Demo functionality and content to help show the power of Panopoly,[core] => 7.x,[package] => Panopoly Demos,[project] => panopoly_demo,[dependencies] => Array ([0] => features,[1] => migrate,[2] => page_manager,[3] => panopoly_pages,[4] => views,[5] => views_content),[stylesheets] => Array ([all] => Array ([panopoly_demo.css] => sites/all/modules/panopoly_demo/panopoly_demo.css)),[features] => Array ([ctools] => Array ([0] => page_manager:pages_default:1,[1] => views:views_default:3.0),[features_api] => Array ([0] => api:2),[page_manager_pages] => Array ([0] => panopoly_demo_panel),[views_view] => Array ([0] => panopoly_demo)),[files] => Array ([0] => import/panopoly_demo.node.inc,[1] => import/panopoly_demo.menu.inc),[version] => 7.x-1.41+0-dev,[datestamp] => 1479408721,[mtime] => 1482250581,[php] => 5.2.4,[bootstrap] => 0)), module) called at [/var/www/panopoly-7.x/modules/system/system.module:2436]
#7  _system_rebuild_module_data() called at [/var/www/panopoly-7.x/modules/system/system.module:2464]
#8  system_rebuild_module_data() called at [/var/www/panopoly-7.x/sites/all/modules/contrib/apps/apps.manifest.inc:19]
#9  apps_server_local(Array ([title] => Panopoly,[description] => Apps for Panopoly,[manifest] => http://apps.getpantheon.com/panopoly-dev,[name] => panopoly)) called at [/var/www/panopoly-7.x/sites/all/modules/contrib/apps/apps.manifest.inc:216]
#10 apps_request_manifest(Array ([title] => Panopoly,[description] => Apps for Panopoly,[manifest] => http://apps.getpantheon.com/panopoly-dev,[name] => panopoly)) called at [/var/www/panopoly-7.x/sites/all/modules/contrib/apps/apps.manifest.inc:420]
#11 apps_manifest(Array ([title] => Panopoly,[description] => Apps for Panopoly,[manifest] => http://apps.getpantheon.com/panopoly-dev,[name] => panopoly)) called at [/var/www/panopoly-7.x/sites/all/modules/contrib/apps/apps.manifest.inc:124]
#12 apps_apps(panopoly, Array ([installed] => 1), 1) called at [/var/www/panopoly-7.x/sites/all/modules/contrib/apps/apps.profile.inc:399]
#13 apps_profile_enable_app_modules(Array ([parameters] => Array ([profile] => panopoly,[locale] => en,[q] => ),[forms] => Array ([install_settings_form] => Array ([driver] => mysql,[mysql] => Array ([database] => panopoly-7.x,[username] => panopoly-7.x,[password] => 9RiDj13CSDqNxA,[host] => mysql,[port] => ,[driver] => mysql,[prefix] => ),[op] => Save and continue),[install_configure_form] => Array ([site_name] => Panopoly,[site_mail] => admin@example.com,[account] => Array ([name] => admin,[mail] => admin@example.com,[pass] => Array ([pass1] => admin,[pass2] => admin)),[update_status_module] => Array ([1] => 1,[2] => 1),[clean_url] => 1,[op] => Save and continue)),[interactive] => ,[active_task] => apps_profile_enable_app_modules_panopoly,[completed_task] => ,[database_tables_exist] => 1,[installation_finished] => ,[locales] => Array (),[parameters_changed] => ,[profile_info] => Array ([name] => Panopoly,[distribution_name] => Panopoly,[description] => A magical framework for building Drupal products based on the Panels module,[core] => 7.x,[exclusive] => 1,[dependencies] => Array ([0] => filter,[1] => system,[2] => node,[3] => user,[4] => field_sql_storage,[5] => text,[6] => field,[7] => block,[8] => menu,[9] => image,[10] => list,[11] => number,[12] => options,[13] => path,[14] => taxonomy,[15] => search,[16] => shortcut,[17] => field_ui,[18] => file,[19] => dblog,[20] => update,[21] => panopoly_core,[22] => panopoly_images,[23] => panopoly_theme,[24] => panopoly_magic,[25] => panopoly_widgets,[26] => panopoly_admin,[27] => panopoly_users,[28] => panopoly_pages,[29] => panopoly_search,[30] => panopoly_wysiwyg,[31] => navbar,[32] => breakpoints,[33] => backports,[34] => simplified_menu_admin,[35] => save_draft,[36] => module_filter,[37] => date_popup_authored,[38] => views_ui,[39] => devel,[40] => distro_update,[41] => uuid,[42] => apps,[55] => ctools,[56] => date,[57] => date_api,[58] => date_popup,[59] => date_views,[60] => defaultconfig,[61] => entity,[62] => entityreference,[63] => features,[64] => field_group,[66] => fieldable_panels_panes,[68] => jquery_update,[69] => libraries,[72] => page_manager,[73] => panelizer,[74] => panels,[75] => panels_breadcrumbs,[76] => panels_ipe,[77] => pathauto,[78] => pm_existing_pages,[79] => strongarm,[80] => token,[81] => transliteration,[82] => views,[83] => views_autocomplete_filters,[84] => views_content,[88] => file_entity,[90] => manualcrop,[91] => media,[94] => radix_layouts,[96] => fape,[108] => link,[111] => media_vimeo,[112] => media_youtube,[113] => menu_block,[117] => simple_gmap,[118] => tablefield,[123] => admin_views,[131] => views_bulk_operations,[141] => user_picture_field,[155] => facetapi,[158] => search_api,[159] => search_api_db,[160] => search_api_facetapi,[161] => search_api_solr,[162] => search_api_views,[166] => caption_filter,[171] => image_resize_filter,[172] => linkit,[174] => media_internet,[176] => media_wysiwyg,[179] => wysiwyg,[180] => wysiwyg_filter),[version] => ,[hidden] => ,[php] => 5.2.4),[profiles] => Array ([testing] => stdClass Object ([uri] => ./profiles/testing/testing.profile,[filename] => testing.profile,[name] => testing),[minimal] => stdClass Object ([uri] => ./profiles/minimal/minimal.profile,[filename] => minimal.profile,[name] => minimal),[panopoly] => stdClass Object ([uri] => ./profiles/panopoly/panopoly.profile,[filename] => panopoly.profile,[name] => panopoly),[standard] => stdClass Object ([uri] => ./profiles/standard/standard.profile,[filename] => standard.profile,[name] => standard)),[server] => Array (),[settings_verified] => 1,[stop_page_request] => ,[task_not_complete] => ,[tasks_performed] => Array ([0] => install_select_profile,[1] => install_select_locale,[2] => install_load_profile,[3] => install_verify_requirements,[4] => install_system_module,[5] => install_bootstrap_full,[6] => install_profile_modules,[7] => install_configure_form,[8] => apps_install_verify,[9] => apps_profile_apps_select_form_panopoly,[10] => apps_profile_download_app_modules_panopoly,[11] => apps_profile_install_app_modules_panopoly))) called at [/var/www/panopoly-7.x/includes/install.core.inc:425]

What's going on is a circular dependency that involves search_api.

'apps' is calling system_rebuild_module_data() which will eventually write the new information about 'panopoly_demo' to the 'system' table. However, before it gets to that point, hook_system_info_alter() is called, and search_api_system_info_alter() tries to discover if the module implements hook_search_api_item_type_info() which leads to drupal_get_filename('module', 'panopoly_demo') -- and that's what's triggering the error, because there is no information about 'panopoly_demo' on the 'system' table. After system_rebuild_module_data() completes, the 'system' table will be updated, so subsequent calls will work, but the error is registered anyway, breaking drush.

I'm trying to determine if what 'search_api' is doing is actually valid, and it's something 'apps' needs to account for, or if we need to update 'search_api' to only check for the hook if the module is enabled or something like that.

Here's a patch that modifies search_api - gonna try it on Travis

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/jobs/185555341

Woohoo! Travis is passing :-) Committed! Thanks, Everyone!