Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).
We need to test:
1) drupal_xml_parser_create() with non- utf-8/iso-8859-1/us-ascii encoding.
2) Multibyte language support (including headers).
3) decode_entities().
Comment | File | Size | Author |
---|---|---|---|
#10 | decode_entities_test.patch | 2.8 KB | grendzy |
#6 | decode_entities_test.patch | 2.85 KB | grendzy |
#5 | decode_entities_test.patch | 2.79 KB | jhedstrom |
#1 | decode_entities_test_01.patch | 2.75 KB | cwgordon7 |
Comments
Comment #1
cwgordon7 CreditAttribution: cwgordon7 commentedLet's start knocking these off. :)
Here's a test case for decode_entities().
Comment #2
catchI'm getting WSOD when I try to run this test, along with 'headers already sent' in watchdog.
common.inc 319:
header('Location: ' . $url, TRUE, $http_response_code);
encoding issue for the new test file maybe? Leaving at needs review in case it's my box.
Comment #3
catchRunning from the command line I see the byte order mark printed to output before the test fails. Sort yer editor out gordon.
Comment #4
cwgordon7 CreditAttribution: cwgordon7 commentedGah... sorry :(
Comment #5
jhedstromThe problem was an erant unicode bit at the beginning of the file. I removed that, and moved the file to the modules/simpletest/tests directory. All the tests still pass.
Comment #6
grendzy CreditAttribution: grendzy commentedI added the list of $excludes to the assertion, which makes debugging a little easier. (this test is helping me work through #212130: decode_entities() doesn't support all entities.
I would also suggest adding a few more entities if / when drupal can decode them:
'—' => '—',
'’' => '’',
Thanks!
Comment #8
grendzy CreditAttribution: grendzy commentedperhaps a victim of #335122: Test clean HEAD after every commit
Comment #9
catchPer http://drupal.org/node/325974 - we no longer have phpdoc for getInfo(). Test itself looks great though.
Comment #10
grendzy CreditAttribution: grendzy commentedremoving phpdoc for getInfo().
Comment #11
lilou CreditAttribution: lilou commentedFollow here : #352359: [core] Fixes for drupal_strpos()