This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:

1) drupal_xml_parser_create() with non- utf-8/iso-8859-1/us-ascii encoding.
2) Multibyte language support (including headers).
3) decode_entities().

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cwgordon7’s picture

Status: Active » Needs review
FileSize
2.75 KB

Let's start knocking these off. :)

Here's a test case for decode_entities().

catch’s picture

I'm getting WSOD when I try to run this test, along with 'headers already sent' in watchdog.

common.inc 319:

header('Location: ' . $url, TRUE, $http_response_code);

encoding issue for the new test file maybe? Leaving at needs review in case it's my box.

catch’s picture

Status: Needs review » Needs work

Running from the command line I see the byte order mark printed to output before the test fails. Sort yer editor out gordon.

cwgordon7’s picture

Gah... sorry :(

jhedstrom’s picture

Status: Needs work » Needs review
FileSize
2.79 KB

The problem was an erant unicode bit at the beginning of the file. I removed that, and moved the file to the modules/simpletest/tests directory. All the tests still pass.

grendzy’s picture

FileSize
2.85 KB

I added the list of $excludes to the assertion, which makes debugging a little easier. (this test is helping me work through #212130: decode_entities() doesn't support all entities.

I would also suggest adding a few more entities if / when drupal can decode them:

'—' => '—',
'’' => '’',

Thanks!

Status: Needs review » Needs work

The last submitted patch failed testing.

grendzy’s picture

Status: Needs work » Needs review
catch’s picture

Status: Needs review » Needs work

Per http://drupal.org/node/325974 - we no longer have phpdoc for getInfo(). Test itself looks great though.

grendzy’s picture

Status: Needs work » Needs review
FileSize
2.8 KB

removing phpdoc for getInfo().

lilou’s picture

Status: Needs review » Closed (duplicate)