CommentFileSizeAuthor
#10 composer-2764335-10.patch548 bytesShreya Shetty
#6 composer-2764335-6.patch0 bytesShreya Shetty
#2 composer-2764335-2.patch415 bytesShreya Shetty
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shreya Shetty created an issue. See original summary.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
FileSize
composer-2764335-2.patch415 bytes
Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
Status: Active » Needs review
steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Component: Documentation » Code
Status: Needs review » Needs work 
  1. +++ b/composer.json
@@ -0,0 +1,10 @@
+  "type": "drupal-module",

    add "keywords": ["Drupal", "context", "block", "visibility", "conditions"] 

  2. +++ b/composer.json
@@ -0,0 +1,10 @@
+  "description": "Provide modules with a cache that lasts for a single page request.",

    Description is not correct. Something like this (from project page): "Manage contextual conditions and reactions for different portions of your site." 

  3. +++ b/composer.json
@@ -0,0 +1,10 @@
+  "homepage": "http://drupal.org/project/context",

    homepage: "https://www.drupal.org/project/context"

steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Version: 8.x-4.x-dev » 8.x-1.x-dev

Don't know why a 8.x-4.x branch even exists. That's 7.x code. This is a 8.x-1.x issue.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
Status: Needs work » Needs review
FileSize
composer-2764335-6.patch0 bytes

Done as per suggestion.

NormySan’s picture

NormySan CreditAttribution: NormySan as a volunteer and at Odd Hill commented

The module does have a composer.json file, https://github.com/oddhill/context/blob/8.x-1.x/composer.json.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented

Yes I just made some improvements.

bighappyface’s picture

bighappyface CreditAttribution: bighappyface as a volunteer commented

@shreya-shetty the second patch (#6) is an empty file.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
FileSize
composer-2764335-10.patch548 bytes

Sorry for the empty patch . Provided patch with improvements

bighappyface’s picture

bighappyface CreditAttribution: bighappyface as a volunteer commented

+1 Simple updates

utement’s picture

utement CreditAttribution: utement at Agiledrop - Your Trusted Drupal Teammates commented
Status: Needs review » Reviewed & tested by the community

Tested.

Ready for commit

boshtian’s picture

boshtian CreditAttribution: boshtian commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.