fel_fields throws missing module warning on cache clear after update to Drupal 7.50

Yep, this is definitely a problem. tsewa's patch should work, but I took a different approach to avoid registering what will effectively be a non-functional theme function. No interdiff due to the simplicity of the patch and the different approach.

The solutions here seems to be one-off for the Field Collection Table module, though I see no reason not to check for other modules as well. As a benefit the theme registry becomes less cluttered.

Suggested patch attached. Please test.

Sorry. Patch was created in wrong order. This is the correct one.

@kaare I have no issue with pulling these other ones out of the theme registry, but the reason we wrote the code as a one-off for the Field Collection Table module is because it's the only one that actually attempts to include a file from the (possibly missing) module.

This change removes the fel_ prefix from the keys for all of these entries...are we sure you're not colliding with any other keys with that change? Also, the relevant theme functions need their names updated if you're going to do that (theme_fel_fields_socialfield_drag_components(), theme_fel_fields_collection_table(), etc) and any relevant usages need updating.

And I'd argue this is a breaking API change as any other modules that either modify these (hook_theme_registry_alter) or use these theme functions will now break.

Given all of this, I think you should avoid renaming the keys.

but the reason we wrote the code as a one-off for the Field Collection Table module is because it's the only one that actually attempts to include a file from the (possibly missing) module.

That's a totally valid reason.

Otherwise, no theme key are renamed here. Only modules not enabled are filtered out. If you dpm() the resulting theme, and compare it with the theme returned prior to this patch, the end result is the same, only with the disabled/missing modules' theme overrides removed. the fel_ prefix is still there.

I have no strong opinion here. Maybe my solution is over-engineered. I really liked the cleanliness/readability of your patch, so I might just go for it :-)

Ah, I didn't read your patch carefully -- I see what you did there. Sorry about that! Looks good to me; and your patch is good defensive coding.

Aight. Consensus reached :-)

I've just replaced Fel with the latest dev version (7.x-1.0-beta2+35-dev), cleaned caches and run update script. Warning is displayed again at the Review updates step.
Any thoughts?

I failed to reproduce this. Could you mix up a recipe where I'm able to trigger this?

Steps I did now was:

• fel* enabled
• Field collections disabled
• Disable/uninstall views
• Downgraded views to 3.11 and installed it
• Upgrade views to 3.14
• Ran update.php

Still couldn't reproduce any warnings/errors.

Hi @kaare. Here's the recipe:

1. Install a fresh Drupal 7.44 site;
2. Add a new content type;
3. Install Field UI, CTools, Form element layout 7.x-1.0-beta2 and Form element layout fields 7.x-1.0-beta2;
4. Go to your content type and add a text field using Fel (I always select Before for text position);
5. Now replace Drupal with version 7.50 and run the update script => at the Review log step you have the first warning;
6. And then replace Fel with the latest dev (2016-Aug-12) and run the update script => at the Review updates step you have the second warning, before finishing database update;

I think that's all the info.

The problem is with the drupal_get_path(), it doesn't matter whether you add the theme definitions or not, the drupal_get_path() always gets called.

So by checking the existence of the module and then calling the drupal_get_path() solves the issue.

I've created an updated patch. This should take care of the warning.

Thx @yce for catching this!

May we have a patch to apply https://www.drupal.org/project/fel/releases/7.x-1.0-beta2 ?
Or a new release ?

Thank you