Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).
Proposed resolution
Create/modify tests
Remaining tasks
We need to test:
1) image_get_available_toolkits()
2) image_get_toolkit() with an invalid toolkit name.
3) image_toolkit_invoke() with an invalid method.
4) image_get_info() on a nonexistent file.
5) image_scale_and_crop()
6) image_scale() with an image already small enough.
7) image_resize()
8) image_rotate()
9) image_crop()
Original report by cwgordon7
This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).
We need to test:
1) image_get_available_toolkits()
2) image_get_toolkit() with an invalid toolkit name.
3) image_toolkit_invoke() with an invalid method.
4) image_get_info() on a nonexistent file.
5) image_scale_and_crop()
6) image_scale() with an image already small enough.
7) image_resize()
8) image_rotate()
9) image_crop()
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 276398-tests-image.inc_.patch | 881 bytes | matason |
Comments
Comment #1
matason CreditAttribution: matason commentedI want to get in on the test writing action!
I've attached a patch which tests image_get_available_toolkits() and I'd like to continue and write tests for the rest of the listed functions.
I'd really appreciate it if someone could take a look at what I've done so far and let me know if I'm on the right lines :)
Sorry but had to change Component from 'tests' to 'other', tests was not available in the Component drop-down.
Thanks!
Comment #2
catchMoving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.
Comment #3
franzThis is old, but might be worth to bring back.
There is a lot of tests implemented already, including the one in the patch. However, we don't seem to have tests that cover everything. I'm editing the summary to clear the list.
Comment #3.0
franzUpdating tests still needing coverage and using issue summary template
Comment #12
quietone CreditAttribution: quietone as a volunteer commentedI don't work with images but some searching and I think that this still needs to be done:
image_scale() with an image already small enough.
Also moving to 'image system' which seems a better fit.