Not every promotion is a discount.

Ryan, Matt and I discussed this, decided to rename the module and entity type to commerce_promotion.
We'll then have the "discount" and "coupon" bundles (promotion types).

CommentFileSizeAuthor
#2 rename_to-2763695-2.patch57.52 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

mglaman’s picture

Status: Active » Needs work
FileSize
57.52 KB

Initial WIP

rszrama’s picture

Is there another issue to discuss the bundles, perhaps? I'm not sold on the need to split along the lines of "discount vs. coupon." I could see using bundles for the type of promotion given the varying fields on them (e.g. percentage discount, flat discount, BOGO, free shipping, etc.), but coupon really just seems like any other condition to me. I'd expect the same conditions to apply to any promotion regardless of type.

bojanz’s picture

Percentage discount, flat discount, BOGO, free shipping, etc will be actions, so I'm guessing their configuration will be stored serialized, just like for conditions.

The need for bundles for coupons is primarily for usage limits: A discount has promotion-level usage limits, a coupon has coupon-code-level usage limits.

mglaman’s picture

Status: Needs work » Fixed

Committed the change from commerce_discount to commerce_promotion

mglaman’s picture

Component: DIscount » Promotions

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.