Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Not every promotion is a discount.
Ryan, Matt and I discussed this, decided to rename the module and entity type to commerce_promotion.
We'll then have the "discount" and "coupon" bundles (promotion types).
Comment | File | Size | Author |
---|---|---|---|
#2 | rename_to-2763695-2.patch | 57.52 KB | mglaman |
Comments
Comment #2
mglamanInitial WIP
Comment #3
rszrama CreditAttribution: rszrama at Centarro commentedIs there another issue to discuss the bundles, perhaps? I'm not sold on the need to split along the lines of "discount vs. coupon." I could see using bundles for the type of promotion given the varying fields on them (e.g. percentage discount, flat discount, BOGO, free shipping, etc.), but coupon really just seems like any other condition to me. I'd expect the same conditions to apply to any promotion regardless of type.
Comment #4
bojanz CreditAttribution: bojanz at Centarro commentedPercentage discount, flat discount, BOGO, free shipping, etc will be actions, so I'm guessing their configuration will be stored serialized, just like for conditions.
The need for bundles for coupons is primarily for usage limits: A discount has promotion-level usage limits, a coupon has coupon-code-level usage limits.
Comment #5
mglamanCommitted the change from commerce_discount to commerce_promotion
Comment #6
mglaman