I try newest version 7.x-1.0-beta11 and version dev also i got big issue. when i delete items (/field-collection/field-child/xxxx/delete)
it delete in data base field collection item and all data revison field children data but it doesn't delete data field children .
I use VBO to delete field collection items it works fine : field collection item , data field child and revision is gone. that means entity delete works fine field_collection_item_delete_confirm_submit have to add field collection -> delete or use entity_delete

Quick test :
SELECT * FROM field_data_field_child_type WHERE entity_id
NOT IN (SELECT field_child_value FROM field_data_field_child)

if field collection delete works it must be 0 but i got a lots of line

CommentFileSizeAuthor
#6 field_collection-field-collection-doesnt-delete-children-data-2763395-6.patch697 bytesAndrew Gorokhovets
#5 field-collection-delete-data-D7.patch764 byteslazzyvn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lazzyvn’s picture

lazzyvn CreditAttribution: lazzyvn commented

/sites/all/modules/contrib/field_collection/field_collection.pages.inc


function field_collection_item_delete_confirm_submit($form, &$form_state) {
  $field_collection_item = $form_state['field_collection_item'];
  //$field_collection_item->deleteRevision();
  entity_delete('field_collection_item',$field_collection_item->item_id);

it works fine

lazzyvn’s picture

lazzyvn CreditAttribution: lazzyvn commented
Issue summary: View changes

I'm not sure to patch in function deleteRevision or use delete entity direct

lazzyvn’s picture

lazzyvn CreditAttribution: lazzyvn commented
Issue summary: View changes

how to create patch ? somme one can show me please

jmuzz’s picture

jmuzz CreditAttribution: jmuzz commented
Priority: Critical » Normal

Thanks lazzyvn.

It would be nice to have this as a patch. It will also need to include an update to clean out any lingering field collection item data that may have been left by the old behaviour.

lazzyvn’s picture

lazzyvn CreditAttribution: lazzyvn commented
FileSize
field-collection-delete-data-D7.patch764 bytes

Here is my patch

Andrew Gorokhovets’s picture

Andrew Gorokhovets CreditAttribution: Andrew Gorokhovets as a volunteer commented
Status: Active » Needs review
FileSize
field_collection-field-collection-doesnt-delete-children-data-2763395-6.patch697 bytes

Updated the patch for the last dev version.

  • ram4nd committed fd84c99 on 7.x-1.x authored by lazzyvn 
    Issue #2763395 by lazzyvn, Andrew Gorokhovets: Field collection doesn't...
ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Needs review » Fixed
Issue tags: -Field collection children data

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.