Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Remove deprecated/underscore functions from search_config.admin.inc and remove this file and move its functions to a helper service
Comment | File | Size | Author |
---|---|---|---|
#9 | 2763341-9.patch | 42.96 KB | naveenvalecha |
#5 | 2763341-5-removeDeprecatedFunctions.patch | 41.31 KB | joyceg |
Comments
Comment #2
naveenvalecha@joyceg,
I have granted you maintain issues permissions so that you can assign us back for getting review.
Comment #3
naveenvalechaComment #4
naveenvalecha@joyceg,
Any plans to work on it ?
Comment #5
joyceg CreditAttribution: joyceg commentedComment #6
joyceg CreditAttribution: joyceg commentedComment #7
joyceg CreditAttribution: joyceg commentedComment #8
naveenvalechado the git pull b/c the patch does not apply anymore after the recent changes.
move this file to a folder call form
like this 'src/Form/SearchConfigForm'
Please also update the namespace accordingly
The whole file misses coding standards and using tabs instead of spaces.
white space at EOL
Comment #9
naveenvalechaThe module path
admin/config/search/pages
was completely broken so I don't know how it was previously tested.Attached patch do the following :
Move the helper function from .admin.inc to search_config.module file
Fix the WSOD that was coming on the screen.
Comment #10
naveenvalechaThings that are needed either in followups :
Comment #12
naveenvalechaCommitted and pushed the code to 8.x-1.x branch
@joyceg,
Please create the followup for the changes needed as mentioned in #10