Remove deprecated/underscore functions from search_config.admin.inc and remove this file and move its functions to a helper service

https://github.com/naveenvalecha/search_config/issues/14

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

Assigned: Unassigned » joyceg

@joyceg,

I have granted you maintain issues permissions so that you can assign us back for getting review.

naveenvalecha’s picture

Issue summary: View changes
naveenvalecha’s picture

@joyceg,
Any plans to work on it ?

joyceg’s picture

joyceg’s picture

Status: Active » Needs review
joyceg’s picture

Assigned: joyceg » naveenvalecha
naveenvalecha’s picture

Assigned: naveenvalecha » joyceg
Status: Needs review » Needs work

do the git pull b/c the patch does not apply anymore after the recent changes.

  1. +++ b/search_config.module
    index e69de29..ff85007 100644
    --- a/src/formbuilder.php
    

    move this file to a folder call form
    like this 'src/Form/SearchConfigForm'
    Please also update the namespace accordingly

  2. +++ b/src/formbuilder.php
    @@ -0,0 +1,381 @@
    +<?php
    

    The whole file misses coding standards and using tabs instead of spaces.

  3. +++ b/src/formbuilder.php
    @@ -0,0 +1,381 @@
    +        $string_overrides = search_config_string_overrides();   ¶
    

    white space at EOL

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
42.96 KB

The module path admin/config/search/pages was completely broken so I don't know how it was previously tested.
Attached patch do the following :

Move the helper function from .admin.inc to search_config.module file
Fix the WSOD that was coming on the screen.

naveenvalecha’s picture

Things that are needed either in followups :

  1. Move the helper functions to new helper service
  2. Fix the commented code in content_node_search_config restrictions settings.

  • naveenvalecha committed f84b6de on 8.x-1.x
    Issue #2763341 by naveenvalecha, joyceg: Remove deprecated/underscore...
naveenvalecha’s picture

Assigned: joyceg » Unassigned
Status: Needs review » Fixed

Committed and pushed the code to 8.x-1.x branch

@joyceg,
Please create the followup for the changes needed as mentioned in #10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.