Failure on comments with no subject [#2763283]

I'm on drupal 8.1.5:

➜  public_html drush pml
 Package              Name                                              Type    Status         Version       
...
 Core (Experimental)  Migrate (migrate)                                 Module  Enabled        8.1.5         
 Core (Experimental)  Migrate Drupal (migrate_drupal)                   Module  Enabled        8.1.5         
 Core (Experimental)  Migrate Drupal UI (migrate_drupal_ui)             Module  Enabled        8.1.5         
...       
 Migrate              Migrate API (migrate_api)                         Module  Enabled        8.x-1.1       
 Migrate              Migrate UI (migrate_ui)                           Module  Enabled        8.x-1.1       
 Migrate              Migrate UI Templates (migrate_ui_templates)       Module  Not installed  8.x-1.1       
 Migration            Drupal Upgrade (migrate_upgrade)                  Module  Enabled        8.x-2.0-beta1 
 Migration            Migrate Example (migrate_example)                 Module  Not installed  8.x-2.0-beta1 
 Migration            Migrate Example (Advanced)                        Module  Not installed  8.x-2.0-beta1 
                      (migrate_example_advanced)                                                             
 Migration            Migrate Plus (migrate_plus)                       Module  Enabled        8.x-2.0-beta1 
 Migration            Migrate Tools (migrate_tools)                     Module  Enabled        8.x-2.0-beta1 
...

Running a basic migrate upgrade from an old d6 database:

➜  public_html drush migrate-upgrade 
...
Attempt to create a field comment_no_subject that does not exist on entity type node.             [error]
(/home/naught101.org/public_html/core/modules/field/src/Entity/FieldConfig.php:286)
...

All of the comments on my site are subjectless comments on blog posts, like this: http://naught101.org/node/131#comments. The comments *do* get migrated, I can see them in admin/content/comment, but they don't show up on the actual blog posts, and I get a notice:

Notice: Undefined index: comment_no_subject in Drupal\comment\Controller\CommentController->commentPermalink() (line 123 of core/modules/comment/src/Controller/CommentController.php).

See e.g. http://163.172.137.64/~naught101.org/node/131 for the migrated version.

When I click on one of the comments from admin/content/comment, I get a WSOD, and the error in the logs is:

[Sat Jul 09 03:33:38.710902 2016] [:error] [pid 16704] [client 101.176.248.106:44224] PHP Fatal error:  Call to a member function getSetting() on null in /home/naught101.org/public_html/core/modules/comment/src/Controller/CommentController.php on line 126, referer: http://163.172.137.64/~naught101.org/admin/content/comment

I haven't found any other comments mentioning this issue. Any support would be welcome, let me know if I can provide any more info.

Comment	File	Size	Author
#13	Issue_2763283-upgrade_migrate_comments_02.patch	1.67 KB	thomas73
#13	8.1.x: PHP 5.5 & MySQL 5.5 18,807 pass
#7	Issue_2763283-upgrade_migrate_comments_01.patch	852 bytes	naught101
#7	8.1.x: PHP 5.5 & MySQL 5.5 18,792 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

9 July 2016 at 03:37

naught101 created an issue. See original summary.

Comment #2

mikeryan

he/him

English

Murphysboro, IL, USA

CreditAttribution: mikeryan at Virtuoso Performance commented 9 July 2016 at 16:32

Project:	Migrate Upgrade	» Drupal core
Version:	8.x-2.x-dev	» 8.1.x-dev
Component:	Code	» migration system
Assigned:	naught101	» Unassigned
Priority:	Major	» Normal

This would be a problem in the migration system, not in the drush front end.

The key message here would be

Attempt to create a field comment_no_subject that does not exist on entity type node. (/home/naught101.org/public_html/core/modules/field/src/Entity/FieldConfig.php:286)

Are there any messages in the migrate_message tables for d6_comment_field or d6_comment_field_instance?

Comment #3

naught101 CreditAttribution: naught101 commented 11 July 2016 at 01:20

Version:	8.1.x-dev	» 9.x-dev
Component:	migration system	» ajax system
Assigned:	Unassigned	» naught101
Priority:	Normal	» Major

Yeah, sorry about that - getting confused about all of the migrate* modules..

In d6_comment_field_instance, there is this:

msgid: 1		
source_ids_hash: 5fe6833818eedfc3fd8b6b7c36015756cb82b9a2476558579584db40cbd7ef92 	
level: 1 	
message: Attempt to create a field comment_no_subject that does not exist on entity type node. (/home/naught101.org/public_html/core/modules/field/src/Entity/FieldConfig.php:286)

No data in any of the other migrate_message_* tables...

I just tried this again with a fresh site install, same result.

Comment #4

naught101 CreditAttribution: naught101 commented 11 July 2016 at 01:21

Version:	9.x-dev	» 8.1.x-dev
Component:	ajax system	» migration system
Assigned:	naught101	» Unassigned
Priority:	Major	» Normal

Argh, WTF... I didn't touch any of those metadata fields...

Comment #5

naught101 CreditAttribution: naught101 commented 1 August 2016 at 02:41

Migration doesn't actually add any comment fields to the new content types (blog post and page).

I'm trying to create the field manually, but I'm not sure if there is a way to do it without tonnes of manual coding, since drush field-create/clone doesn't work in drupal 8. and I'm not even sure that that would work anyway..

Comment #6

naught101 CreditAttribution: naught101 commented 1 August 2016 at 03:01

Hrm... it looks to me like the logic at http://cgit.drupalcode.org/drupal/tree/core/modules/comment/src/Plugin/m... and http://cgit.drupalcode.org/drupal/tree/core/modules/comment/src/Plugin/m... are inverted. But maybe I'm reading it wrong...

Comment #7

naught101 CreditAttribution: naught101 commented 1 August 2016 at 03:18

Status:

Active

» Needs review

File	Size
Issue_2763283-upgrade_migrate_comments_01.patch	852 bytes
8.1.x: PHP 5.5 & MySQL 5.5 18,792 pass, 1 fail

Yep. This works. The comment fields now migrate correctly, however, the display is disabled by default. Easy enough to enable manually though.

Comment #8

1 August 2016 at 03:52

Status:

Needs review

» Needs work

The last submitted patch, 7: Issue_2763283-upgrade_migrate_comments_01.patch, failed testing.

File	Size
Issue_2763283-upgrade_migrate_comments_02.patch	1.67 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,807 pass

Test fixed as well.

Comment #14

chx CreditAttribution: chx at Smartsheet commented 13 August 2016 at 17:13

Status:

Needs work

» Reviewed & tested by the community

Yes, that test made no sense. Look at it: page is the first row, and it is on comment_subject_field_page is serialize(1) . And yet we tested that it became comment_no_subject which is wrong.

Comment #15

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 13 August 2016 at 22:53

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed 24343f9 to 8.3.x and 146dabc to 8.2.x and 94becf0 to 8.1.x. Thanks!

Nice that we were testing the broken behaviour :)

Comment #16

13 August 2016 at 22:53

alexpott committed 24343f9 on 8.3.x

Issue #2763283 by naught101, thomas73: Failure on comments with no...

Comment #17

13 August 2016 at 22:53

alexpott committed 146dabc on 8.2.x

Issue #2763283 by naught101, thomas73: Failure on comments with no...

Comment #18

chx CreditAttribution: chx at Smartsheet commented 14 August 2016 at 04:33

I called out rote and pointless testing in https://medium.com/@chx/the-terrible-cycle-of-contributing-to-drupal-cor... 3. Most of the source plugin unit tests could be nuked safely because they are pointless and only exist because everything must be tested.