Add access modifier for method getSubscribedEvents to classes implemented EventSubscriberInterface [#2762101]

I have found in core that some classes which implemented an interface EventSubscriberInterface does not have access modifier for the method getSubscribedEvents(), which should be declared with access modifier.

See API documentation for the interface EventSubscriberInterface .

This issue is valid for all version of Drupal 8.

Comment	File	Size	Author
#8	2762101-add-access-modifier.patch	21.38 KB	ddrozdik
#8	8.4.x: PHP 5.6 & MySQL 5.5 21,639 pass
#3	2762101-add-access-modifier-8.2.x.patch	21.74 KB	ddrozdik
#3	8.2.x: PHP 5.5 & MySQL 5.5 20,910 pass, 5 fail 8.3.x: PHP 5.6 & MySQL 5.5 20,938 pass, 1 fail
#2	2762101-add-access-modifier-8.1.x.patch	21.74 KB	ddrozdik
#2	8.1.x: PHP 5.5 & MySQL 5.5 18,656 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

7 July 2016 at 10:45

ddrozdik created an issue. See original summary.

Comment #2

ddrozdik CreditAttribution: ddrozdik as a volunteer and at Drupal Ukraine Community commented 7 July 2016 at 10:46

Status:

Active

» Needs review

File	Size
2762101-add-access-modifier-8.1.x.patch	21.74 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,656 pass

Here is patch to review, implemented to 8.1.x version.

Comment #3

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW, Drupal Ukraine Community for FFW commented 26 July 2016 at 19:42

Version:

8.1.x-dev

» 8.2.x-dev

File	Size
2762101-add-access-modifier-8.2.x.patch	21.74 KB
8.2.x: PHP 5.5 & MySQL 5.5 20,910 pass, 5 fail 8.3.x: PHP 5.6 & MySQL 5.5 20,938 pass, 1 fail

File

Size

2762101-add-access-modifier-8.2.x.patch

21.74 KB

8.2.x:
PHP 5.5 & MySQL 5.5 20,910 pass, 5 fail

8.3.x:
PHP 5.6 & MySQL 5.5 20,938 pass, 1 fail

I have updated patch for 8.2 version.

Comment #4

26 July 2016 at 19:42

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #5

4 September 2016 at 17:23

Status:

Needs review

» Needs work

The last submitted patch, 3: 2762101-add-access-modifier-8.2.x.patch, failed testing.

Comment #6

Sutharsan CreditAttribution: Sutharsan commented 29 September 2016 at 14:34

Issue tags:

-Novice

Removing Novice. Fixing these failing tests requires more than that.

Comment #7

29 September 2016 at 14:34

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #8

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW, Drupal Ukraine Community for FFW commented 19 February 2017 at 21:07

Status:

Needs work

» Needs review

File	Size
2762101-add-access-modifier.patch	21.38 KB
8.4.x: PHP 5.6 & MySQL 5.5 21,639 pass

2 files were hidden/shown/deleted

File	Size
2762101-add-access-modifier-8.1.x.patch	21.74 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,656 pass
2762101-add-access-modifier-8.2.x.patch	21.74 KB
8.2.x: PHP 5.5 & MySQL 5.5 20,910 pass, 5 fail 8.3.x: PHP 5.6 & MySQL 5.5 20,938 pass, 1 fail

Updated the patch again.

Comment #9

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW, Drupal Ukraine Community for FFW commented 20 February 2017 at 11:32

Assigned:

ddrozdik

» Unassigned

Comment #10

20 February 2017 at 11:32

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #11

20 February 2017 at 11:32

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.