Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The module no longer works without an API key.
Comment | File | Size | Author |
---|---|---|---|
#17 | requires_api_key-2761595-17.patch | 7.73 KB | Gertjan.k |
#15 | Screenshot from 2016-07-22 20:55:47.png | 174.48 KB | Manuel Garcia |
#13 | patch-result-1.png | 23.34 KB | ashwinsh |
#13 | patch-result.png | 26.2 KB | ashwinsh |
#8 | requires_api_key-2761595-8.patch | 7.57 KB | Manuel Garcia |
Comments
Comment #2
ashwinshI will look for this.
Comment #3
ashwinshHello @FranCarstens,
I have attached a patch for this issue, please review it.
Now users can choose an google api key or a 'for Work' client id. It will also provides a warning on the status report page if an api key or client id is not provided so that users are aware it.
Added configuration link for this module. (Reference Path: /admin/config/content/styled_google_map)
Thank you,
AshwinSh
Comment #4
FranCarstens CreditAttribution: FranCarstens as a volunteer commentedThanks AshwinSh, I will test this tonight.
Comment #5
FranCarstens CreditAttribution: FranCarstens as a volunteer commentedThe patch applied without a problem and the module is functioning perfectly.
Thanks again, AshwinSh!
Comment #7
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer commentedI made the port to 8.x version of this patch. Need somebody to test more.
Special thanks to @ashwin.shaharkar for help.
Comment #8
Manuel Garcia CreditAttribution: Manuel Garcia at Appnovation commentedHere is a reroll of the patch on #3 that applies cleanly to 7.x-2.x
I've tested this locally and it works, code looks ok to me as well, thanks @ashwin.shaharkar!
Comment #9
ashwinshThank you @Manuel Garcia for your review.
I have compared your patch file with my patch file, it seems that you just added spaces and removed @file comments code which is not related to this issue.
Regards,
Comment #10
Manuel Garcia CreditAttribution: Manuel Garcia at Appnovation commented@ashwin.shaharkar I re-rolled your patch because it would not apply to 7.x-2.x cleanly.
Comment #11
kopeboy CreditAttribution: kopeboy commentedWhich Google Maps API do we need?
Please add documentation.
Maps JavaScript API, or
Maps Embed API ?
I went here to get the key: https://developers.google.com/maps/documentation/javascript/get-api-key#...
and after setting up I immediately got the error
This site has exceeded its daily quota for maps. If you are the creator of this site, please visit the <a href="https://developers.google.com/maps/faq#usagelimits?utm_referrer=v3" target="_blank">documentation</a> to learn more.
even if my website has no visits!
UPDATE: ok, it did that for some minutes, now is back to working.
Comment #12
Manuel Garcia CreditAttribution: Manuel Garcia at Appnovation commentedMaps Embed API afik, at least thats what I used. Make sure to limit it to the domain you're going to use it for.
UPDATE: Didn't read your update.
Comment #13
ashwinshHi @Manuel Garcia,
I have checked my patch file and seems that it is cleanly apply to 7.x-2.x. I have attached two screen-shot for this, please check it.
Thank you
Comment #14
FranCarstens CreditAttribution: FranCarstens as a volunteer commentedAshwin's patch applied cleanly to 7.x-2.x-dev for me as well. Maybe Manuel Garcia was using 7.x-2.0?
Comment #15
Manuel Garcia CreditAttribution: Manuel Garcia at Appnovation commentedYour patch would not apply to the git 7.x-2.x branch of the module, which is where the maintainer of the module will need to apply the patch to.
Steps to reproduce:
1. Clone the project:
git clone --branch 7.x-2.x https://git.drupal.org/project/styled_google_map.git
2. Get in to the cloned repo directory:
cd styled_google_map
3. Download the patch:
wget https://www.drupal.org/files/issues/added-google-api-key-configuration.patch
4. Try to apply the patch:
git apply -v added-google-api-key-configuration.patch
Results:
My patch does apply cleanly to this branch, so the module maintainer can just take it and use that without having to re-roll it himself.
I'm only trying to be helpful here that's all. I attach a screenshot if you're curious =)
Comment #17
Gertjan.k CreditAttribution: Gertjan.k commentedI couldn't get either patches to apply cleanly to the latest release (7.x-2.0). So i rerolled #8 again.
Comment #18
Kaz de Groot CreditAttribution: Kaz de Groot commented#17 makes admin_menu flake out due to the problem described here: https://www.drupal.org/node/1622904#comment-10768958
Comment #20
iampumaAdded configuration to the 7.x-2.x branch. @KazdeGroot not having any issues though with the admin_menu module.
Comment #21
iampumaComment #22
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer commentedComment #23
metroecho CreditAttribution: metroecho commentedThe map works when I add the key, but it will not geolocate. Remove the key and no map but will geolocate. I am using IP Geolocation Views & Maps and in the views either config will not have an effect on the views map. Any suggestions ?
Comment #24
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer commentedmetroecho,
Try to check IP Geolocation Views issue queue. Google Maps API doesn't allow to geolocate without API key. Style Google Maps is using the key only to display the map (that is also required by Google), the module itself doesn't do any geolocation.
I would also appreciate if you give more details. Maybe also with some example links, if possible.