The documentation for hook_modules_installed() still refers twice to \Drupal\Core\Extension\ModuleHandler::install() although this has been replaced by \Drupal\Core\Extension\ModuleInstaller::install() in https://www.drupal.org/node/1894902.

Some (all ?) locations where this still exists are:

  • hook_modules_installed($modules) (2)
  • module_set_weight()
  • InstallerServiceProvider::alter()
  • LanguageNegotiator::purgeConfiguration() and ::updateConfiguration() (4 in all: install and uninstall)
  • ModuleHandlerTest::testDependencyResolution() and ::testDependencyResolution() (3 install and 1 uninstall, although the logic is correct, this is just in the error messages), and 5 uninstall in testUninstallContentDependency()
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fgm created an issue. See original summary.

cilefen’s picture

Issue tags: +Documentation
fgm’s picture

dawehner’s picture

Component: base system » extension system
Status: Needs review » Reviewed & tested by the community

Lovely! I like how this issue was really easy to review :)

  • xjm committed f8bd3f7 on 8.2.x
    Issue #2760883 by fgm: API docs reference ModuleHandler::install()...

  • xjm committed 04bd1bd on 8.1.x
    Issue #2760883 by fgm: API docs reference ModuleHandler::install()...
xjm’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs followup

I confirmed this covers all the instances that might be formatted differently as well, with:
grep -rh "install(" * | grep -i "handler"

The remaining references are all related to themes instead. Can we have a followup issue to fix the references to the deprecated theme handler as well?

Committed and pushed to 8.2.x and 8.1.x. Thanks!

fgm’s picture

And follow tests come back green : anyone to review ?

  • xjm committed f8bd3f7 on 8.3.x
    Issue #2760883 by fgm: API docs reference ModuleHandler::install()...

  • xjm committed f8bd3f7 on 8.3.x
    Issue #2760883 by fgm: API docs reference ModuleHandler::install()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.