I want type strictness wherever possible - our schema has a few fields that are booleans and should be marked as such.

in case other modules are building on the flag module this change should be made as early as possible.

Here is the original drive behind this issue

This is a logic bug - without consequence ... I think --- Anyway I want to tidy it up!

From flag.schema.yml

show_on_profile is a boolean

so in the flag_follower module

flag.flag.follower.yml -> show_on_profile should not be NULL

Correct?

CommentFileSizeAuthor
#15 bool-2760453-15.patch2.67 KBmartin107
#12 bool-2760453-12.patch490 bytesmartin107
bool-1.patch458 bytesmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Fixed

Thanks!

  • joachim committed 0230579 on 8.x-4.x authored by martin107 
    Issue #2760453 by martin107: Fixed config install value should be 0...

  • joachim committed 4ac53fc on 8.x-4.x 
    Revert "Issue #2760453 by martin107: Fixed config install value should...
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Fixed » Active

I reverted this because it broke tests!

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented

[Me: with hangdog expression ]

Do you know which one(s) .... I will investigate.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented

The errors were about the type of the value in flag_following config.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Active » Needs review
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented

Hmmm why can't I trigger another test of the patch?

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Needs work
martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented

My one line patch needs reroll :)... just kidding.

I am going to unhide the patch ... to see if the test results become visible.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs work » Needs review
FileSize
bool-2760453-12.patch490 bytes

I have repeated many tests locally but can't find any test that fails ... I want testbot to set me straight.

Status: Needs review » Needs work

The last submitted patch, 12: bool-2760453-12.patch, failed testing.

The last submitted patch, 12: bool-2760453-12.patch, failed testing.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Title: show_on_profile should never be null. » Make schema enforce boolean types
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +alpha blocker
FileSize
bool-2760453-15.patch2.67 KB

So in the schema there are a few mis-typed booleans I want to enforce them all.

show_as_field
show_on_form
show_contextual_links
show_on_profile
access_ui

issue summary changes:
1) To signal a major change. departure from the original intent of the issue.
2) Justify why this is an alpha blocker.

  • joachim committed 9b2d7e4 on 8.x-4.x authored by martin107 
    Issue #2760453 by martin107: Fixed schema properties not declared as...
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Fixed

Tests are green this time, so committing!

Thanks! I really appreciate your attention to detail :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.