Removing deprecated functions from code base [#2759475]

There are multiple uses of deprecated DB-functions like db_select, db_insert, db_query violations.

Comment	File	Size	Author
#4	2759475-4.patch	153.62 KB	rajeshwari10
#4	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.2 214 pass
#2	2759475-2.patch	153.62 KB	rajeshwari10
#2	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass, 25 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 July 2016 at 22:02

rajeshwari10 created an issue. See original summary.

File	Size
2759475-2.patch	153.62 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass, 25 fail

Comment #3

1 July 2016 at 22:18

Status:

Needs review

» Needs work

The last submitted patch, 2: 2759475-2.patch, failed testing.

Comment #4

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented 1 July 2016 at 22:33

Status:

Needs work

» Needs review

File	Size
2759475-4.patch	153.62 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.2 214 pass

Comment #5

TR CreditAttribution: TR commented 2 July 2016 at 03:17

Priority:	Normal	» Minor
Status:	Needs review	» Needs work
Issue tags:	-deprecated

For uc_fulfillment, I'd prefer not to make any changes. When Package and Shipment are converted to entities, direct queries of the database will not be needed - any changes to the db_ functions here will just disappear.

Also, with the OO code, I would prefer to inject the db connection if possible rather than use the static methods on Database. The static methods should be used in the procedural code only.

Note that although these functions are technically deprecated, they will not disappear until Drupal 9, which is probably 5 years away. So I'd rather take the time to do this correctly rather than rush to remove the current working code.