Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Added RTL css for Rules Components tab.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-4-6.txt | 3.16 KB | elaman |
| #6 | rules_ui_rtl-2759199-6.patch | 6.92 KB | elaman |
| #4 | rules_ui_rtl-2759199-4.patch | 3.73 KB | elaman |
| |||
| rules_ui-rtl_css.patch | 392 bytes | hmazurkiewicz | |
Comments
Comment #2
TR CreditAttribution: TR commentedThere's a lot more than that one float that needs to be changed for RTL support. Please make a patch that contains ALL the changes needed for RTL, and please pay attention to the coding standards for RTL support as outlined in https://www.drupal.org/node/222782
Comment #3
TR CreditAttribution: TR commentedAnyone interested in helping out? How about you RTL folks? This is an easy one ...
Comment #4
elaman@TR, I've rerolled the patch based on your comment.
Comment #5
TR CreditAttribution: TR commentedThanks! It looks like you forgot to include the rtl.css files in your patch?
A quick review also shows a couple of styles that should be marked LTR but aren't. These are in rules.ui.css:
Line 25
padding-left: 0px
Line 60
right: 0px
Note that even though they are both 0px, they override the inherited style and change it. So these are both LTR styles.
Comment #6
elamanComment #8
TR CreditAttribution: TR commentedThanks. I fixed the "\ No newline at end of file" in the patch for ui/rules.ui.seven-rtl.css, and I added @file documentation blocks at the top of the files.
Committed!