The implementation of hook_user_delete calls ga_login_delete_code(), but if you are trying to delete spam users who do not have an entry in the ga_login table, you will get the "There was a problem deleting the GA Login code" code. (I'm also using the patch in #1834290 to make GA Login required for some users but not others, so I have lots of users without GA Logins in the DB).

This is a confusing message to see when you are trying to delete a user -- and it makes it seem like the user deletion didn't work. Attached is a patch that runs db_delete on the GA Login table without calling ga_login_delete_code().

CommentFileSizeAuthor
#4 2758683-ga_login-user_deletion_error-4.patch1.53 KBanbarasan.r
#2 2758683-ga_login-user_deletion_error-2.patch448 bytessjancich
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sjancich created an issue. See original summary.

sjancich’s picture

sjancich CreditAttribution: sjancich commented
FileSize
2758683-ga_login-user_deletion_error-2.patch448 bytes
attiks’s picture

attiks CreditAttribution: attiks at Attiks commented
Version: 7.x-1.7 » 7.x-1.x-dev
Status: Active » Needs work

Is there a reason you didn't use _ga_login_account_has_code to check if there is a code?

anbarasan.r’s picture

anbarasan.r CreditAttribution: anbarasan.r at NBCUniversal commented
FileSize
2758683-ga_login-user_deletion_error-4.patch1.53 KB

I used the below patch.

anbarasan.r’s picture

anbarasan.r CreditAttribution: anbarasan.r at NBCUniversal commented
Status: Needs work » Needs review
dbjpanda’s picture

dbjpanda CreditAttribution: dbjpanda commented
Assigned: Unassigned » dbjpanda

Going to review