Need to change !placeholder in t() [#2758617]

In D7, placeholders for t() would begin with either @, %, or !. Placeholders beginning @ were passed through check_plain(), placeholders beginning %were wrapped in tags and passed through check_plain(), and placeholders beginning ! were raw HTML to be added unchanged.

In D8, the placeholder prefix ! has been deprecated, as discussed in https://www.drupal.org/node/2506427

So the Devel module code need to update accordingly. Thanks.

Comment	File	Size	Author
#2	placeholder_2758617.patch	13.65 KB	jalpesh
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 29 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

30 June 2016 at 13:24

jalpesh created an issue. See original summary.

Comment #2

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented 30 June 2016 at 13:26

Assigned:	jalpesh	» Unassigned
Status:	Active	» Needs review

File	Size
placeholder_2758617.patch	13.65 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 29 pass

I have added a patch for same. Thanks.

Comment #3

lussoluca

he/him

Italian

Italy

CreditAttribution: lussoluca at H2H Creative Productions commented 13 July 2016 at 16:34

Status:

Needs review

» Reviewed & tested by the community

There's a lot to work for porting devel_node_access to D8 but this is a good start.

Comment #4

22 July 2016 at 13:03

salvis committed d4a4c82 on 8.x-1.x

Issue #2758617 by jalpesh: Need to change !placeholder in t().

Comment #5

salvis

he/his

CreditAttribution: salvis commented 22 July 2016 at 13:05

Status:

Reviewed & tested by the community

» Fixed

+++ b/devel_node_access/src/Plugin/Block/DnaBlock.php
@@ -544,10 +544,10 @@ class DnaBlock extends BlockBase implements ContainerFactoryPluginInterface {
-          '#markup' => t("You have errors in your !na table! You may be able to fix these for now by running !Rebuild_permissions, but this is likely to destroy the evidence and make it impossible to identify the underlying issues. If you don't fix those, the errors will probably come back again. <br /> DON'T do this just yet if you intend to ask for help with this situation.", $variables),
+          '#markup' => t("You have errors in your !na table! You may be able to fix these for now by running @Rebuild_permissions, but this is likely to destroy the evidence and make it impossible to identify the underlying issues. If you don't fix those, the errors will probably come back again. <br /> DON'T do this just yet if you intend to ask for help with this situation.", $variables),

Here's another !na -- I'm fixing that one as well. :-)

Thanks for the patch, jalpesh!