README file is missing.

CommentFileSizeAuthor
#5 views_slideshow-8.x-4.x-require-readme-file-2758353-5.patch1.53 KBDYdave
#2 require_readme_file-2758353-2.patch1.41 KBSumit Gawde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sumit Gawde created an issue. See original summary.

Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented
FileSize
require_readme_file-2758353-2.patch1.41 KB

Adding patch.

Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: require_readme_file-2758353-2.patch, failed testing.

DYdave’s picture

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented
Title: Require README file » Add the README.txt file
Assigned: Sumit Gawde » Unassigned
Category: Bug report » Task
Status: Needs work » Needs review
FileSize
views_slideshow-8.x-4.x-require-readme-file-2758353-5.patch1.53 KB

@Sumit Gawde,
Strange result..... Not sure why the patch didn't apply....
Error message was:

/var/lib/drupalci/web/jenkins-default-162607/modules/views_slideshow/require_readme_file-2758353-2.patch
error: README.txt: No such file or directory
Patch Failed to apply

 
Anyhow, trying a re-roll (with a few line breaks to avoid going over 80 characters per line) with a different name, let's see...
Patch attached as: views_slideshow-8.x-4.x-require-readme-file-2758353-5.patch.

Hope that helps...
Cheers!

Status: Needs review » Needs work

The last submitted patch, 5: views_slideshow-8.x-4.x-require-readme-file-2758353-5.patch, failed testing.

DYdave’s picture

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented

Simple, check the console output of views_slideshow-8.x-4.x-require-readme-file-2758353-5_0.patch test with PHP 5.5 & MySQL 5.5, Drupal 8.2.x:

11:02:34   ERROR: No valid tests were specified.

 
views_slideshow-8.x-4.x currently has no Tests.

Ideally, automated testing could be disabled for this branch, in order to manually review and keep issues in Needs review status.
Thanks in advance to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!

Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented

@DYdave,

Ah... I was wondering what was the issue..

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Needs work » Fixed

Adding a bit more details/modifying a few things, but this was definitely needed.
Thanks for getting this started!

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented

Committed the updated readme, thanks for the patch

  • NickWilde committed 40e96b5 on 8.x-4.x 
    Task: Issue #2758353 by Sumit Gawde, DYdave, NickWilde: Add the README....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.