Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

Status: Active » Needs review
balajidharma’s picture

Component: Documentation » Code
Category: Plan » Feature request
Priority: Critical » Normal
Status: Needs review » Postponed

Now it's not good to implement HTML5 download. Because most of the browser not supported. We can implement in future.

joseph.olstad’s picture

Most browsers? All current Chrome, Firefox support it.
Edge supports html5 also.

balajidharma’s picture

Not supported Safari and IE old version (only support IE 13).

joseph.olstad’s picture

IE is deprecated. IE 11 is the last one. There is no IE 13

https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support

balajidharma’s picture

IE 13 is a Edge browser(http://www.w3schools.com/tags/att_a_download.asp). We can add HTML5 download was additional feature, like use HTML5 download attribute as optional (to add option in admin side).

balajidharma’s picture

Category: Feature request » Task
Status: Postponed » Needs review
StatusFileSize
new4.9 KB

I have added patch to support HTML5 download attribute.

Branch: 7.x-2.x-dev

balajidharma’s picture

StatusFileSize
new4.13 KB

Added patch for branch 7.x-1.x

kristofferwiklund’s picture

Status: Needs review » Needs work

Branch 1.x is dead, so I removed that patch file.

But reviewing the code there is lot of duplicated code in this patch. Should be able to have the "use_html_attr"-code in one function that is called 5 times.

balajidharma’s picture

Hi Kristoffer Wiklund,

Yes sure, i will update.

Thanks

balajidharma’s picture

Version: 7.x-1.x-dev » 7.x-2.1
Status: Needs work » Needs review
StatusFileSize
new4.64 KB

I have used common function now. Kindly review it.

Branch: 7.x-2.x

kristofferwiklund’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

astonvictor’s picture

Status: Reviewed & tested by the community » Closed (outdated)

D7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.