Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

StatusFileSize
new565 bytes
dishabhadra’s picture

Assigned: dishabhadra » Unassigned
Status: Active » Needs review
kunalkursija’s picture

Status: Needs review » Reviewed & tested by the community
rakesh.gectcr’s picture

Status: Reviewed & tested by the community » Needs work

Can we run through all the code base ? and get a patch please

girish-jerk’s picture

Assigned: Unassigned » girish-jerk
girish-jerk’s picture

Status: Needs work » Needs review
StatusFileSize
new11.95 KB

Hi all,

Have fixed all the coding standard issues.
please review.

Thanks

rakesh.gectcr’s picture

Status: Needs review » Needs work
+++ b/Tests/Controller/BasicSearchTest.php
@@ -1,18 +1,18 @@
 /**
  * @file
  * Contains \Drupal\custom_solr_search\Tests\BasicSearch.
  */

+++ b/src/Form/SearchForm.php
@@ -1,12 +1,11 @@
 /**
  * @file
  * Contains \Drupal\custom_solr_search\Form\SearchForm.
  */

We should be removing all the @file block from the module. @file should be only in .module file

rakesh.gectcr’s picture

dhruveshdtripathi’s picture

Assigned: girish-jerk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new11.72 KB
new1.77 KB

did changes mentioned in #8