As per coding Standard there needs to be docblock in files.

CommentFileSizeAuthor
#10 interdiff_7-10.txt1.77 KBdhruveshdtripathi
#10 adding_docblock_in_files-2757759-10.patch11.72 KBdhruveshdtripathi
#7 adding_docblock_in_files-2757759-07.patch11.95 KBgirish-jerk
#2 adding_docblock_in_files-2757759-2.patch565 bytesdishabhadra

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
StatusFileSize
new adding_docblock_in_files-2757759-2.patch565 bytes
dishabhadra’s picture

dishabhadra commented
Assigned: dishabhadra » Unassigned
Status: Active » Needs review
kunalkursija’s picture

kunalkursija commented
Status: Needs review » Reviewed & tested by the community
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Reviewed & tested by the community » Needs work

Can we run through all the code base ? and get a patch please

girish-jerk’s picture

girish-jerk commented
Assigned: Unassigned » girish-jerk
girish-jerk’s picture

girish-jerk commented
Status: Needs work » Needs review
StatusFileSize
new adding_docblock_in_files-2757759-07.patch11.95 KB

Hi all,

Have fixed all the coding standard issues.
please review.

Thanks

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Needs work 
+++ b/Tests/Controller/BasicSearchTest.php
@@ -1,18 +1,18 @@
 /**
  * @file
  * Contains \Drupal\custom_solr_search\Tests\BasicSearch.
  */

+++ b/src/Form/SearchForm.php
@@ -1,12 +1,11 @@
 /**
  * @file
  * Contains \Drupal\custom_solr_search\Form\SearchForm.
  */

We should be removing all the @file block from the module. @file should be only in .module file

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
dhruveshdtripathi’s picture

dhruveshdtripathi commented
Assigned: girish-jerk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new adding_docblock_in_files-2757759-10.patch11.72 KB
new interdiff_7-10.txt1.77 KB

did changes mentioned in #8