Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neerajsingh created an issue. See original summary.

neerajsingh’s picture

Assigned: Unassigned » neerajsingh
Status: Active » Needs work
neerajsingh’s picture

Assigned: neerajsingh » Unassigned
Status: Needs work » Needs review
FileSize
656 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 3: 2757703-3.patch, failed testing.

MegaChriz’s picture

  1. PHP Parse error: syntax error, unexpected ')' in modules/feeds/src/EventSubscriber/PubSubHubbub.php on line 169
  2. The Url class used in PubSubHubbub.php is "GuzzleHttp\Url", not "\Drupal\Core\Url". "\Drupal\Core\Url" should be imported at the top of the file using the "use" keyword. Since that will result into a name collision, one of the two referenced classes should be aliased using the "as" keyword like in the following example:
    use My\Full\Classname as Another;
    

    See also http://php.net/manual/en/language.namespaces.importing.php

neerajsingh’s picture

Assigned: Unassigned » neerajsingh
neerajsingh’s picture

Assigned: neerajsingh » Unassigned
Status: Needs work » Needs review
FileSize
884 bytes

@MegaChriz, Thank you for the guidance.. am adding the updated patch here..

  • MegaChriz committed a62adba on 8.x-3.x authored by neerajsingh
    Issue #2757703 by neerajsingh: Replaced deprecated \Drupal::url() with...
MegaChriz’s picture

Status: Needs review » Fixed

Looks good to me. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.