Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Tests with asserts from assertLegacyTrait are deprecated and will be removed in 9.0.x.
For example, assertTrue() and assertFalse() should be replaced by assertNotEmpty() and assertEmpty().
This is a meta issue, each sub-modules should have their own issue and should be listed here.
Comment | File | Size | Author |
---|---|---|---|
#5 | replace_deprecated-2757585-5.patch | 55.84 KB | mglaman |
#2 | assertions_deprecated_base.patch | 7.52 KB | mbreden |
Comments
Comment #2
mbreden CreditAttribution: mbreden at Acro Commerce commentedAdded a patch for the base commerce module tests here.
I've updated some non-deprecated asserts to be more relevant, ie
I've changed to
As well as updating deprecated assertions.
If this is the way we want to move forward, then I will update the rest of the sub modules.
Comment #3
bojanz CreditAttribution: bojanz at Centarro commentedLooks great, let's do this everywhere.
Setting to "needs work" to indicate that the patch needs to be expanded.
Comment #4
mglamanLet's just do them all here, right now, and tighten it up.
Comment #5
mglamanQuick and find and replace with PhpStorm, seems to have gotten them all.
PR: https://github.com/drupalcommerce/commerce/pull/604
Comment #7
mglaman