As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#8 removed-file-tag-2756913-8.patch338 bytesurvashi_vora
#7 file-tag-removed-2756913-7.patch673 bytesurvashi_vora
#2 2756913-2.patch19.27 KBVinay15

Issue fork file_entity-2756913

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Vinay15 created an issue. See original summary.

Vinay15’s picture

Vinay15
he/him
Primary language Marathi
Location Navi Mumbai
CreditAttribution: Vinay15 at Blisstering Solutions commented
Assigned: Vinay15 » Unassigned
Status: Active » Needs review
FileSize
2756913-2.patch19.27 KB

Removed @file docs.

Status: Needs review » Needs work

The last submitted patch, 2: 2756913-2.patch, failed testing.

The last submitted patch, 2: 2756913-2.patch, failed testing.

urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
Assigned: Unassigned » urvashi_vora

Hi,

I will work on this.

urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented

I will apply a patch shortly.

urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
Assigned: urvashi_vora » Unassigned
Status: Needs work » Needs review
FileSize
file-tag-removed-2756913-7.patch673 bytes

Hi,

Please review this patch.

Thanks

urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
FileSize
removed-file-tag-2756913-8.patch338 bytes

Sorry, mistakenly applied the patch in a different branch.

Please review this patch.

JatinGupta40’s picture

JatinGupta40 CreditAttribution: JatinGupta40 as a volunteer and at QED42 for Drupal India Association commented
Assigned: Unassigned » JatinGupta40

I will reviw this patch.

JatinGupta40’s picture

JatinGupta40 CreditAttribution: JatinGupta40 as a volunteer and at QED42 for Drupal India Association commented
Assigned: JatinGupta40 » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch #8 is applied cleanly, and it removes all the @file tags from all the .php files.
Moving to RTBC
Thanks

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Closed (works as designed)

The point is to remove @file from class files, not php files. This is not a class. api.php files are supposed to have this.