[D7] Bootstrap Login Authenticate

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Fixing tag, wrong tag name.

Hi ajayNimbolkar,
Validation error must show inside modal popup box. Right now it is showing behind the model.

Automated Review

Please fix issue reported By PAReview.sh:
http://pareview.sh/pareview/httpgitdrupalorgsandboxajaynimbolkar2757047git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

No: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) Not working for me , I am attaching the screenshot. May be i am missing some thing if Yes then please update the Readme doc.
2. (+) Please add hook_help

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi

I did a manual review of your module and please see my comments below.

1. Found alert in bootstrap_login_authenticate.js file. Login form already showing error messages within form. There is no need to show messages using javascript alert. If it is added for testing purpose please remove it. It is an application blocker now.
   

   $('#login-modal #edit-submit').click(function () {
           setTimeout(function () {
             alert('Text: ' + $('.messages').text());
           }, 10000);
         });
   

2. Use "use strict" mode in bootstrap_login_authenticate.js javascript. Refer JavaScript coding standards.
3. bootstrap_login_authenticate_theme(): In hook_theme() you are setting variable 'data' to the template 'bootstrap_login_authenticate_login_output'. But not using it anywhere in the theme function.
   

   /**
    * Implements hook_theme().
    */
   function bootstrap_login_authenticate_theme($existing, $type, $theme, $path) {
     return array(
       'bootstrap_login_authenticate_login_output' => array(
         'variables' => array('data' => NULL),
       ),
     );
   }

4. All user facing text should pass through t().
   Found below in bootstrap_login_authenticate.module

   <div class="modal-footer">
                 <ul class="menu">
                   <li>
                     <a href="#" data-toggle="modal" data-target="#create-account" id ="loginRegister" >Create new account</a>
                   </li>
                   <li>
                     <a href="#" data-toggle="modal" data-target="#forgot_pass" id ="forgotPass">Request new password</a>
                   </li>
                 </ul>
               </div>
   

5. If a multivalue field is there in registration form, then while adding data to the field 'Request new Password' and 'Login' forms are repeatedly displaying over registration form. Check screenshot attached.
6. Close button on error message not working.
7. There is no way to close login popup once it is displayed. So that users cannot access public content in the site without login.
8. Even administrator is restricting users from creating account in the site, still link "Create new account" link is displaying in popup. Then if user is clicking on it, popup is closing and overlay still remains and users cannot access the site.
9. How this module is depends on ctools? If not, remove ctools module dependency from info file.

Thanks,
ARUN AK

Automated Review

http://pareview.sh/pareview/httpgitdrupalorgsandboxajaynimbolkar2757047git

Please configure the default branch properly in git.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

No: Does not follow the guidelines for master branch. Default git branch needs to be set.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template. Please remove the ctools project link from "Requirements" section if that is not dependency.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) For me at first it didn't work since jquery version was less than 1.9. Please update about jquery version in README.txt.
2. (+) Please add @param and @return doc under each hooks and theme function. Please check Doxygen and comment formatting conventions for details.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I see bullet points for Create new account & Request new password links
I am attaching the screenshot
My chrome and firefox versions are 46 and 35

Forgot password
Register
Empty Field Validation works but the error messages, shouldn't they be retained in their respective pages instead of login page?

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2805591

Project 2: https://www.drupal.org/node/2756909

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.