Followup of #2755693: Call to undefined function hosting_get_most_recent_task. There are no visible errors anywhere, but when backup is set to automatically run a backup task every hour, no tasks are spawned and no backups are run.

CommentFileSizeAuthor
#3 backup_tasks_are_not-2756411-3.patch943 byteshelmo

Comments

Neograph734 created an issue. See original summary.

sozkara’s picture

sozkara commented

I have the same issue, no backup tasks are generated. Noticed some odd entries in the hosting-dispatch debug which may be related:

Dispatching queues. [1.36 sec, 27.92 MB]                                                                                 [notice]
Acquired lock on backup_queue queue. [1.4 sec, 27.98 MB]                                                                 [notice]
Too early for queue backup_queue. [1.4 sec, 27.98 MB]                                                                    [notice]
Releasing backup_queue lock. [1.4 sec, 27.99 MB]                                                                         [notice]
Acquired lock on civicrm_cron queue. [1.42 sec, 27.99 MB]                                                                [notice]
Acquired lock on backup_gc queue. [1.51 sec, 28 MB]                                                                      [notice]
Too early for queue backup_gc. [1.51 sec, 28 MB]                                                                         [notice]
Releasing backup_gc lock. [1.51 sec, 28 MB]                                                                              [notice]
Acquired lock on tasks queue. [1.54 sec, 28 MB]                                                                          [notice]
helmo’s picture

helmo commented
Status: Active » Needs review
StatusFileSize
new backup_tasks_are_not-2756411-3.patch943 bytes

I tracked it down ... introduced in #1063674: Only start a new backup if the previous one has completed

Please try this patch.

sozkara’s picture

sozkara commented

@helmo tried patch with latest hosting 7.x-3.x dev installed, and can confirm backup tasks are created as usual. thanks!

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Yes, confirming that a minute after applying the patch automated backups were generated. Good find helmo.

  • helmo committed 254ca1e on 7.x-3.x 
    Issue #2756411 by helmo: Backup tasks are not being generated
helmo’s picture

helmo commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Has anyone here tried weekly or monthly backups with this fix? I'm wondering if #2270539: Only daily backups retained, no weeklies or monthlies can be confirmed.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented

A combination of the dev version of Hosting along with the dev version of Hosting Site Backup Manager is required (both have not received an update since the patches) for backups to work. Having the development version of one of them likely does not work either.

I can confirm dailies work. Never tried weeklies.