Problem/Motivation

After #2625696: Make migrations themselves plugins instead of config entities \Drupal\migrate\MigrationStorage is unused, but it still exists.

Proposed resolution

Remove \Drupal\migrate\MigrationStorage and \Drupal\Tests\migrate\Unit\MigrationStorageTest.

Remaining tasks

User interface changes

None.

API changes

None, as this is not an API. Would be nice to write a change notice, though.

Data model changes

None.

CommentFileSizeAuthor
#4 MigrationStorage-drupal-2756311-2.patch10.04 KBchgasparoto
#2 remove-MigrationStorage-2756311-2.patch21.96 KBkamalrajsahu21
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

kamalrajsahu21’s picture

kamalrajsahu21 CreditAttribution: kamalrajsahu21 at Intelliswift commented
Status: Active » Needs review
FileSize
remove-MigrationStorage-2756311-2.patch21.96 KB

Here is the patch for the same. Please review it

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs review » Needs work

The patch removes MigrationSourceTest instead of MigrationStorageTest.

chgasparoto’s picture

chgasparoto CreditAttribution: chgasparoto as a volunteer and at CI&T commented
Status: Needs work » Needs review
FileSize
MigrationStorage-drupal-2756311-2.patch10.04 KB

Please review.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented

That looks good to me, thanks! Let's see if it's green.

The last submitted patch, 2: remove-MigrationStorage-2756311-2.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Muy bien! ;-)

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Virtuoso Performance for Acquia commented

No need for a change notice, I think. +1 to removing obsolete cruft.

kamalrajsahu21’s picture

kamalrajsahu21 CreditAttribution: kamalrajsahu21 at Intelliswift commented

Oops.. by mistaken I remove MigrateSourceTest.php instead of MigrationStorageTest.php

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.1.x-dev » 8.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 4520b25 and pushed to 8.2.x. Thanks!

  • catch committed 4520b25 on 8.2.x 
    Issue #2756311 by kamalrajsahu21, chgasparoto: MigrationStorage is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.