CommentFileSizeAuthor
#7 interdiff-5-7.txt1.74 KBajalan065
#7 Tests-added-2756157-8-7.patch1.73 KBajalan065
#5 Configure-link-2756157-8-5.patch343 bytesajalan065
#2 configure-link_2756157.patch343 bytesjalpesh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

jalpesh’s picture

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented
FileSize
configure-link_2756157.patch343 bytes

Here you go with configure link on module page. Thanks.

jalpesh’s picture

jalpesh CreditAttribution: jalpesh as a volunteer and at Cybage Software Pvt Ltd. commented
Status: Active » Needs review
ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 at Google Summer of Code commented
Assigned: Unassigned » ajalan065
ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 at Google Summer of Code commented
FileSize
Configure-link-2756157-8-5.patch343 bytes

Though the patch was already uploaded, but just uploading it as a task of my GSOC project.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Status: Needs review » Needs work 
+++ b/google_vision.info.yml
@@ -4,4 +4,5 @@ type: module
\ No newline at end of file

Add a new line at EOF. Add the test for this as well.

Test Case :

1. drupalGet -> admin/modules
2. assertLinkbyHref -> admin/config/.......

ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 at Google Summer of Code commented
FileSize
Tests-added-2756157-8-7.patch1.73 KB
interdiff-5-7.txt1.74 KB
ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 at Google Summer of Code commented
Status: Needs work » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Assigned: ajalan065 » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks!

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.