Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rajeshwari10 created an issue. See original summary.

rajeshwari10’s picture

Status: Active » Needs review
FileSize
37.99 KB

replaced entityManager with entityTypeManager.

Please review.

Thanks!!

Status: Needs review » Needs work

The last submitted patch, 2: 2755833-2.patch, failed testing.

rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
38 KB

Replaced entityTypeManager with Drupal service in field.module for getFieldMapByFieldType()function.

Status: Needs review » Needs work

The last submitted patch, 4: 2755833-4.patch, failed testing.

rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
37.95 KB

Replaced \Drupal::service('entity_type.manager')->getDefinition with \Drupal::entityTypeManager()->getDefinition.

Status: Needs review » Needs work

The last submitted patch, 6: 2755833-6.patch, failed testing.

rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
37.93 KB

Status: Needs review » Needs work

The last submitted patch, 8: 2755833-8.patch, failed testing.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

Deprecated functionality should be removed by concept, not by file or module. It would be better to replace each specific pattern throughout core in separate issues. For example, see my recent comment on #2639682: Replace deprecated get('entity.manager') with get('entity_type.manager'). Another issue could do this exact replacement throughout core, if it's valid:

+++ b/core/modules/field/field.module
@@ -212,7 +212,7 @@ function field_entity_bundle_field_info(EntityTypeInterface $entity_type, $bundl
-  $storage = \Drupal::entityManager()->getStorage('field_config');
+  $storage = \Drupal::entityTypeManager()->getStorage('field_config');

And so on.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Berdir’s picture

Status: Needs work » Closed (duplicate)