Default value for region dropdown while Adding custom block through any particular region "place Block link".

Here is the fix. Please review it.

Wrong patch. Watch comment #8

Sorry I uploaded the wrong patch. This is the right patch. Please review it.

Reuploading and testing it.

+++ b/core/modules/block_content/src/Plugin/Menu/LocalAction/BlockContentAddLocalAction.php
@@ -17,10 +17,15 @@ class BlockContentAddLocalAction extends LocalActionDefault {
   public function getOptions(RouteMatchInterface $route_match) {
     $options = parent::getOptions($route_match);
+
     // If the route specifies a theme, append it to the query string.

I think @Harish is mentioning this line. And as per coding standard, I guess inline commenting does not need the extra line. Please check this. https://www.drupal.org/node/1354

@Harish Please use dreditor in future. It will help you to review the patches.

Thank you for your reviews. I removed the extra line.

This looks like a great usability improvement. Thanks a lot for working on this.

+        if ($region = \Drupal::request()->query->get('region')) {

Rather than \Drupal::request(), let's use $this->getRequest() (per @effulgentsia), since we should have that context from the form.

Additionally, the test needs a bit more working.

+          $opt = array('plugin_id' => 'block_content:' . $block->uuid(), 'theme' => $theme);
+          // Region for the url.
+          $url = $this->getUrl();
+          $url_pieces = explode("?", $url);
+          foreach ($url_pieces as $u) {
+            if (strstr($u, 'region=')) {
+              $region = explode('=', $u);
+              $opt['region'] = $region[1];
+            }
+          }
+          $this->assertUrl(\Drupal::url('block.admin_add', $opt, array('absolute' => TRUE)));

It seems like we'd be better off to test the end result (e.g. that the region name is correctly selected by default in the drop-down and/or that the block showed up on the front-end in the correct region) rather than query string argument being passed correctly, which is more testing the routing system than this specific change.

Also, tested the patch and can confirm that it works! :)

changes as suggested in #17. Please verify.

Hello @webchick. Thank you for reviewing the patch.

I made the changes in BlockContentForm, but I still need to do the corrections in the Test, so I am leaving this in Needs work. I will check it as soon as I get some spare time.
In BlockContentAddLocalAction I used \Drupal::request(), as there is no form created yet. Do you suggest that I do it in some other way or is this ok?

Not actively part of the Blocks-Layouts work.