Allow use of HTML5 placeholder attribute [#2754819]

Allow people to use the HTML5 placeholder attribute instead of label if they so desire.

Comment	File	Size	Author
#25	allow_use_of_html5-2754819-25-codestyle.patch	2.22 KB	helmo
#25	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#25	allow_use_of_html5-2754819-25.patch	5.25 KB	helmo
#25	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#22	allow_use_of_html5_placeholder_attribute_2754819-23.patch	8.04 KB	Perignon
#22	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#18	allow_use_of_html5_placeholder_attribute_2754819-18.patch	6.49 KB	mchampsee
#18	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#15	allow_use_of_html5_placeholder_attribute_2754819-15.patch	9.7 KB	mchampsee
#15	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#12	allow_use_of_html5_placeholder_attribute_2754819-11.patch	11.7 KB	mchampsee
#12	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#10	allow_use_of_html5_placeholder_attribute_2754819-10.patch	8.56 KB	Perignon
#10	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#9	allow_use_of_html5_placeholder_attribute_2754819-9.patch	8.87 KB	Perignon
#9	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#2	mailchimp-placeholder-2754819-2.patch	5.61 KB	mchampsee
#2	7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

24 June 2016 at 03:45

mchampsee created an issue. See original summary.

Comment #2

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 24 June 2016 at 03:49

File	Size
mailchimp-placeholder-2754819-2.patch	5.61 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Comment #3

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 5 July 2016 at 19:53

Status:

Active

» Needs review

Comment #4

Perignon CreditAttribution: Perignon commented 6 July 2016 at 10:06

Status:

Needs review

» Needs work

Functionally, this patch works but needs a little cleanup. Three instances of white spaces in the patch.

I'll be glad to clean them up if you want me to.

Comment #6

Perignon CreditAttribution: Perignon commented 6 July 2016 at 10:07

Dreditor isn't pasting in all the code I commented on correctly. Deleting.

Comment #7

ShaneOnABike CreditAttribution: ShaneOnABike commented 17 July 2016 at 18:41

I can confirm that this patch works magically on the latest dev build THANK YOU!

Comment #8

Perignon CreditAttribution: Perignon commented 17 July 2016 at 18:50

Yes patch works, just needs cleaned up.

Comment #9

Perignon CreditAttribution: Perignon commented 17 July 2016 at 19:12

Status:

Needs work

» Reviewed & tested by the community

File	Size
allow_use_of_html5_placeholder_attribute_2754819-9.patch	8.87 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

1 file was hidden/shown/deleted

File	Size
mailchimp-placeholder-2754819-2.patch	5.61 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

This is a cleaned up patch removing the whitespaces. Corrected the PHPDoc parameters and fixed a code style issue with using else if

Comment #10

Perignon CreditAttribution: Perignon commented 17 July 2016 at 19:15

File	Size
allow_use_of_html5_placeholder_attribute_2754819-10.patch	8.56 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

1 file was hidden/shown/deleted

File	Size
allow_use_of_html5_placeholder_attribute_2754819-9.patch	8.87 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Crap. Missed a few carriage returns. Fixed in this patch.

Comment #11

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 19 July 2016 at 02:02

Fixed two issues that I found:
1)If you upgrade on an existing site with existing signup forms, PHP will throw a warning that it can't find the placeholder variable
2)Changed so that placeholder will not be applied to radio and dropdown fields

Comment #12

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 19 July 2016 at 02:03

File	Size
allow_use_of_html5_placeholder_attribute_2754819-11.patch	11.7 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Comment #13

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 19 July 2016 at 02:04

Status:

Reviewed & tested by the community

» Needs review

Comment #14

Perignon CreditAttribution: Perignon commented 19 July 2016 at 05:09

Status:

Needs review

» Needs work

The latest patch will not apply as it is created against a tagged release of 7.x-4.4. Please re-roll patch against the development branch 7.x-4.x.

Comment #15

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 25 July 2016 at 19:07

File	Size
allow_use_of_html5_placeholder_attribute_2754819-15.patch	9.7 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

oops.

Comment #16

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 30 July 2016 at 18:27

Status:

Needs work

» Needs review

Comment #17

Perignon CreditAttribution: Perignon commented 30 July 2016 at 18:37

Crap. Dev changed again.

Comment #18

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 4 August 2016 at 20:54

File	Size
allow_use_of_html5_placeholder_attribute_2754819-18.patch	6.49 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Re-rolled against latest dev release

Comment #19

idebr CreditAttribution: idebr commented 5 August 2016 at 07:09

Instead of removing the #title property, why not apply '#title_display' => 'invisible'? This leaves the renderable array intact for other modules, and provides accessibility benefits as well, see https://api.drupal.org/api/drupal/developer%21topics%21forms_api_referen...

Comment #20

Perignon CreditAttribution: Perignon commented 5 August 2016 at 10:48

And I also cannot apply this patch with a fresh pull from D.O

Comment #21

Perignon CreditAttribution: Perignon commented 5 August 2016 at 10:54

So I found why it will not apply. It is this piece of code

@@ -495,7 +495,10 @@ function mailchimp_subscribe_process($list_id, $email, $merge_vars = NULL, $inte
       // Clear user cache, just in case there's some cruft leftover:
       mailchimp_cache_clear_member($list_id, $email);
       watchdog('mailchimp', '@email was subscribed to list @list.',
-        array('@email' => $merge_vars['EMAIL'], '@list' => $list_id), WATCHDOG_NOTICE
+        array(
+          '@email' => $merge_vars['EMAIL'],
+          '@list' => $list_id,
+        ), WATCHDOG_NOTICE
       );
     }
     else {

Comment #22

Perignon CreditAttribution: Perignon commented 5 August 2016 at 10:57

File	Size
allow_use_of_html5_placeholder_attribute_2754819-23.patch	8.04 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

I yanked out the part that isn't working. It was just an array formating to multi-line

Comment #23

Perignon CreditAttribution: Perignon commented 5 August 2016 at 11:34

I can only think of the Title (label) being retained for legacy purposes. I say it would be a toss up to make them hidden or just delete them as he has done.

Comment #24

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented 17 August 2016 at 00:09

For what it's worth, I reached out to a blind colleague who had said that he could "see" the fields using this module.

Comment #25

helmo CreditAttribution: helmo at Initfour websolutions commented 2 December 2016 at 08:55

Status:

Needs review

» Reviewed & tested by the community

File	Size
allow_use_of_html5-2754819-25.patch	5.25 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
allow_use_of_html5-2754819-25-codestyle.patch	2.22 KB
7.x-4.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Here's a re-roll.... it broke because of the included code style changes.
I've split it in two patch files.

The effect is OK

Comment #26

koppie CreditAttribution: koppie at Exygy for Cohere commented 19 September 2017 at 20:24

+1 for RTBC. Can we get this in the dev branch???

Comment #27

Greg Boggs

he/him

English

Portland Oregon

CreditAttribution: Greg Boggs at ThinkShout commented 19 September 2017 at 20:27

You'll need to apply the patch for the moment. But, we'll update this issue as soon as the code is committed.

Comment #28

6 October 2017 at 20:04

ruscoe committed 015fab0 on 7.x-4.x authored by helmo

Issue #2754819 by mchampsee, Perignon, helmo: Allow use of HTML5...

Comment #29

6 October 2017 at 20:07

ruscoe credited ruscoe.

Comment #30

ruscoe CreditAttribution: ruscoe at ThinkShout for Mailchimp commented 6 October 2017 at 20:07

Status:

Reviewed & tested by the community

» Fixed

Works great, thank you. Committed to the dev branch.

Comment #31

20 October 2017 at 20:10

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Allow use of HTML5 placeholder attribute

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

Comment #28

Comment #29

Comment #30

Comment #31

Referenced by

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community