We need to start covering existing javascript functionality within Views with test, see #2752931: [meta] Implement Javascript testing for Views and the Views UI.

This is about adding test coverage to the basic search functionality in the Views listing.

Search for some terms and see if the right Views are visible.

CommentFileSizeAuthor
#10 views_listing_test-2753791-10.patch4.56 KBLendude
#10 interdiff-2753791-10.patch972 bytesLendude
#7 views_listing_test-2753791-7.patch4.56 KBLendude
#7 interdiff-2753791-4-7.txt2.22 KBLendude
#4 views_listing_test-2753791-4.patch3.01 KBLendude
#4 interdiff-2753791-2-4.txt1.04 KBLendude
#2 views_listing_test-2753791-2.patch3.08 KBLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Assigned: Lendude » Unassigned
FileSize
views_listing_test-2753791-2.patch3.08 KB

First stab at it.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Status: Active » Needs review
Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
FileSize
interdiff-2753791-2-4.txt1.04 KB
views_listing_test-2753791-4.patch3.01 KB

Self review.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
  1. +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/ViewsListingTest.php
@@ -0,0 +1,87 @@
+  /**
+   * Tests the filtering on the Views listing page.
+   */
+  public function testFilterViewsListing() {

    Just as a suggestion: we could test the disable/enable functionality and the ajax behaviour on that. 

  2. +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/ViewsListingTest.php
@@ -0,0 +1,87 @@
+
+    // Filter on the string 'people'. This should only show the people view.
+    $search_input = $page->find('css', '.views-filter-text.form-search');
+    $search_input->setValue('people');
...
+
+    // Filter on a string that also appears in the description.
+    $search_input->setValue('content');

    Nice tests!

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
FileSize
interdiff-2753791-4-7.txt2.22 KB
views_listing_test-2753791-7.patch4.56 KB

Yeah testing the enabled/disabled functionality would be a great addition, so here we go!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Nice! One step forward in time!

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Status: Reviewed & tested by the community » Needs work

Hi, thanks for your amazing work on these issues and your valuable advices.
I found two little tidbits here. The test is passing because the button and link are currently designed to totally fill their container. If, someday, we chose to change the style of these elements, tests could fail strangely.
We have to be really careful about the things we click on ;)

  1. +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/ViewsListingTest.php
@@ -0,0 +1,123 @@
+    $enabled_view->find('css', 'li.dropbutton-toggle')->click();

    We should target the <button> here. 

  2. +++ b/core/modules/views_ui/tests/src/FunctionalJavascript/ViewsListingTest.php
@@ -0,0 +1,123 @@
+    $disable_button = $enabled_view->find('css', 'li.disable.dropbutton-action');

    We should target the <a> here.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Status: Needs work » Needs review
FileSize
interdiff-2753791-10.patch972 bytes
views_listing_test-2753791-10.patch4.56 KB

@DuaelFR thanks for the feedback! Updated per #9

The last submitted patch, 10: interdiff-2753791-10.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

We should target the here.
We should target the here.

This is a really good point. We should keep that in mind when we review patches!

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Related issues: +#1848940: When enabling or disabling a View, don't move the cursor to the top of the page

Just for the record, this issue is blocking #1848940: When enabling or disabling a View, don't move the cursor to the top of the page (because of the tests).

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: views_listing_test-2753791-10.patch, failed testing.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Status: Needs work » Reviewed & tested by the community

unrelated fails

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: views_listing_test-2753791-10.patch, failed testing.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Status: Needs work » Reviewed & tested by the community

and more unrelated fails.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: views_listing_test-2753791-10.patch, failed testing.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Status: Needs work » Reviewed & tested by the community

Unrelated fails, back to RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: views_listing_test-2753791-10.patch, failed testing.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at Noctilaris commented
Status: Needs work » Reviewed & tested by the community

unrelated fails

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 9cae523573991a87319abfa83f7ee6db9ee9f5c7 to 8.2.x and 69836b2 to 8.1.x. Thanks!

  • alexpott committed 9cae523 on 8.2.x 
    Issue #2753791 by Lendude: Add javascript testing for the Views listing...

  • alexpott committed 69836b2 on 8.1.x 
    Issue #2753791 by Lendude: Add javascript testing for the Views listing...
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

Lendude++

  • alexpott committed 9cae523 on 8.3.x 
    Issue #2753791 by Lendude: Add javascript testing for the Views listing...

  • alexpott committed 9cae523 on 8.3.x 
    Issue #2753791 by Lendude: Add javascript testing for the Views listing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.