Problem/Motivation

The Filter module is the only module that uses "Save changes" instead of simply "Save", and "changes" really is not needed on admin/config/content/formats.
Changing the wording would improve usability by making the page consistent with other admin pages.

Proposed resolution

Change the wording of the button to "Save".

Remaining tasks

Check whether the wording also needs to be changed in tests and/or the hook_help text.

User interface changes

This is a UI interface text change and therefore might need changes in the hook_help text as well.

API changes

Data model changes

CommentFileSizeAuthor
#23 drulenium_admin-people-roles.gif77.19 KBTechNikh
#17 save_changes_to_save-2753049-17.patch3.76 KBpguillard
#11 shortcuts.jpg149.5 KBChandeepKhosa
#11 formats.jpg251.07 KBChandeepKhosa
#9 save_changes_to_save-2753049-9.patch2.56 KBpguillard
#6 shortcuts_after.png22.91 KBpguillard
#6 shortcuts_before.png28.63 KBpguillard
#3 2753049-3.patch1.21 KBpashupathi nath gajawada
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

Looks like a double-post #2753061: Change "Save changes" to "Save"

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Assigned: Unassigned » pashupathi nath gajawada
Status: Active » Needs review
FileSize
2753049-3.patch1.21 KB

hi ,

#2753061 , This is a double post.

Plesae find the patch .

cilefen’s picture

cilefen CreditAttribution: cilefen commented

Please close this or the other one.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented

@cilefen I have closed the other issue #2753061.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Assigned: pashupathi nath gajawada » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
shortcuts_before.png28.63 KB
shortcuts_after.png22.91 KB

Obviously this one is RTBC

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Thanks,

this works as intended.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Reviewed & tested by the community » Needs work

Actually,
this is a patch for the Shortcut module in issue #2753061: Change "Save changes" to "Save" while this is a similar issue for the filter module as it says in the issue description.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs work » Needs review
FileSize
save_changes_to_save-2753049-9.patch2.56 KB

Oops sorry.
I wanted to make reviews, but since I'm here, here is a patch.

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Assigned: Unassigned » ChandeepKhosa

am reviewing

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Issue summary: View changes
FileSize
formats.jpg251.07 KB
shortcuts.jpg149.5 KB

I tested the latest patch with SimplyTest, and have attached the following screenshots from the Formats & Shortcuts pages. I was a little confused from reading the issue description so thought this was best for someone to review.

If it's helpful the SimplyTest site is still available for the next 6 hours here https://rrhrl.ply.st/ (user & password = admin).

Screenshots

Shortcuts

Formats

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Assigned: ChandeepKhosa » Unassigned

.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer and commented
Status: Needs review » Reviewed & tested by the community
ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Sorry for the confusion with two issues with the same title.

As also confirmed in #11, this patch changes the Save button of the Filter module.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs work

Marked #2753061: Change "Save changes" to "Save" as a duplicate of this issue. Since this is exactly the same string in both patches, we should fix it within a single issue scope. See https://www.drupal.org/core/scope for more information. So let's combine the two patches.

Edit: I confirmed that the contributors from the other issue are also listed here.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Assigned: Unassigned » pguillard
pguillard’s picture

pguillard CreditAttribution: pguillard commented
Assigned: pguillard » Unassigned
Status: Needs work » Needs review
FileSize
save_changes_to_save-2753049-17.patch3.76 KB

Here is a combined patch (shortcut & filter)

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Thanks,
this patch fixes the Save button for on Filter formats and Shortcut links.
Just waiting to for the testbot before RTBCing it.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs review » Reviewed & tested by the community

  • xjm committed 3e07700 on 8.2.x 
    Issue #2753049 by pguillard, pashupathi nath gajawada, ChandeepKhosa,...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Fixed

Thanks @pguillard! Looks like we are getting all the strings like that now:

[mandelbrot:maintainer | Fri 13:05:06] $ grep -ri "save changes" *
[mandelbrot:maintainer | Fri 13:05:20] $

This change reduces unneeded text in the UI (and makes our buttons consistent) which improves usability. Committed 3e07700 and pushed to 8.2.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +String change in 8.2.0

(But actually not such a big string change as it is switching to a string which will already be translated.)

TechNikh’s picture

TechNikh CreditAttribution: TechNikh commented
Status: Fixed » Active
FileSize
drulenium_admin-people-roles.gif77.19 KB

I don't think this is intended but I noticed that this patch caused the "Save Order" button on the Roles page "/admin/people/roles" to change to "Save" button.
Here is the before & after GIF of the page "admin/people/roles" generated by Automated visual regression suite http://drulenium.org/
Drulenium GIF

TechNikh’s picture

TechNikh CreditAttribution: TechNikh commented
Status: Active » Fixed

My bad. Looks like it was intended as part of #2753055: Change "Save order" to "Save"
Marking this to Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.