Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I can't tell yet if the bug is only a bug in the UI or whether it affects the functionality. However, when attempting to add two separate fields as Temporary Targets, the first shows up as "Temporary target 1" (as expected) and the second shows up as "Missing".
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | qbxml_import_party.tamper.txt | 10.38 KB | geru |
| #7 | qbxml_import_party.importer.txt | 5.77 KB | geru |
| #7 | Screenshot from 2017-02-15 21-26-50.png | 98.56 KB | geru |
| #4 | feeds_tamper-missing-temporary-target-2752661-4.patch | 4.97 KB | MegaChriz |
| #4 | feeds-missing-temporary-target-2752661-4.patch | 1.26 KB | MegaChriz |
| |||
Comments
Comment #2
MegaChriz CreditAttribution: MegaChriz at WebCoo commentedIt looks like a compatibility issue between Feeds and Feeds Tamper, but it seems to only affect the UI. I think this is caused by the changes from #2542416: Allow sources and targets to be defined but hidden..
I tested if temporary targets still work this way:
GUID: [guid].URL: [url].[guid]\n[url].The body field of all created nodes contained "GUID: " and "URL: ", which were added by the rewrite tamper plugins from the temporary targets.
Comment #3
NWOM CreditAttribution: NWOM commentedThanks for testing. I can confirm after testing yesterday as well that it works as expected. So, I agree that it is probably just a UI issue.
Comment #4
MegaChriz CreditAttribution: MegaChriz at WebCoo commentedThe attached two patches - one for Feeds and one for Feeds Tamper - should fix the issue.
Basically what happens is that building the list of available sources and targets is moved from the theme function to the form builder function, so that Feeds Tamper can add extra targets via a form alter.
Comment #5
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedAlso created an issue for Feeds Tamper: #2852921: 2nd Temporary Target shows as "Missing".
Comment #6
geru CreditAttribution: geru commentedI have applied these two patches and confirm that it fixed the problem for me. Thank you.
Comment #7
geru CreditAttribution: geru commentedActually, upon further inspection, it mostly fixed the problem.
In the uploaded screenshot, you can see that 'blank source 4', which maps to a non-temporary target is shown associated with "missing" instead of its real target, which, in this case, is called 'bc_type'
I've attached screenshot and exports of the feeds importer and feeds tamper definitions.
I'm also not sure if this is the same issue, or a new one.
Comment #8
MegaChriz CreditAttribution: MegaChriz as a volunteer commented@geru
Thanks for testing! Can you show an export of your other configuration as well (fields, entity types) in the form of a feature module?
I have no idea what 'bc_type' is and it will show up as missing as well when the property or field is not defined on my local system.
Comment #9
geru CreditAttribution: geru commentedMy bad. The bc_type really is missing. I feel silly. Works great. Thank you.
Comment #10
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedNo need to feel silly! I'm already glad that you took the time to test the patch.
Comment #12
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedPatch for Feeds is committed! Now, Feeds Tamper still need to be fixed. But that only can be done after a new release of Feeds is made.