As noted by others, the form needs some work. saving works fine.

Notice: Undefined property: Drupal\authorization\Form\AuthorizationProfileForm::$providerPluginManager in Drupal\authorization\Form\AuthorizationProfileForm->getProviderPluginManager() (line 69 of modules/contrib/authorization/src/Form/AuthorizationProfileForm.php).
Notice: Undefined property: Drupal\authorization\Form\AuthorizationProfileForm::$consumerPluginManager in Drupal\authorization\Form\AuthorizationProfileForm->getConsumerPluginManager() (line 79 of modules/contrib/authorization/src/Form/AuthorizationProfileForm.php).
Strict warning: Declaration of Drupal\authorization\Provider\ProviderPluginBase::submitRowForm() should be compatible with Drupal\authorization\Plugin\ConfigurablePluginBase::submitRowForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state) in include() (line 17 of modules/contrib/authorization/src/Provider/ProviderPluginBase.php).
Strict warning: Declaration of Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider::buildRowDescription() should be compatible with Drupal\authorization\Plugin\ConfigurablePluginBase::buildRowDescription(array $form, Drupal\Core\Form\FormStateInterface $form_state) in include() (line 17 of modules/contrib/ldap/ldap_authorization/src/Plugin/authorization/Provider/LDAPAuthorizationProvider.php).
Strict warning: Declaration of Drupal\authorization\Consumer\ConsumerPluginBase::submitRowForm() should be compatible with Drupal\authorization\Plugin\ConfigurablePluginBase::submitRowForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state) in include() (line 17 of modules/contrib/authorization/src/Consumer/ConsumerPluginBase.php).
Strict warning: Declaration of Drupal\authorization_drupal_roles\Plugin\authorization\consumer\DrupalRolesConsumer::submitRowForm() should be compatible with Drupal\authorization\Consumer\ConsumerPluginBase::submitRowForm(array &$form, Drupal\authorization\Form\SubFormState $form_state) in include() (line 20 of modules/contrib/authorization/authorization_drupal_roles/src/Plugin/authorization/Consumer/DrupalRolesConsumer.php).
Notice: Undefined property: Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider::$consumer in Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider->buildConfigurationForm() (line 81 of modules/contrib/ldap/ldap_authorization/src/Plugin/authorization/Provider/LDAPAuthorizationProvider.php).
Notice: Undefined property: Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider::$mappings in Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider->buildConfigurationForm() (line 110 of modules/contrib/ldap/ldap_authorization/src/Plugin/authorization/Provider/LDAPAuthorizationProvider.php).
Notice: Undefined property: Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider::$useMappingsAsFilter in Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider->buildConfigurationForm() (line 110 of modules/contrib/ldap/ldap_authorization/src/Plugin/authorization/Provider/LDAPAuthorizationProvider.php).
Notice: Undefined property: Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider::$useFirstAttrAsGroupId in Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider->buildConfigurationForm() (line 110 of modules/contrib/ldap/ldap_authorization/src/Plugin/authorization/Provider/LDAPAuthorizationProvider.php).
Notice: Undefined property: Drupal\authorization\Form\AuthorizationProfileForm::$provider in Drupal\authorization\Form\AuthorizationProfileForm->buildConditionsForm() (line 353 of modules/contrib/authorization/src/Form/AuthorizationProfileForm.php).
Notice: Undefined property: Drupal\authorization\Form\AuthorizationProfileForm::$consumer in Drupal\authorization\Form\AuthorizationProfileForm->buildConditionsForm() (line 356 of modules/contrib/authorization/src/Form/AuthorizationProfileForm.php).
Notice: Undefined property: Drupal\authorization\Form\AuthorizationProfileForm::$synchOnLogon in Drupal\authorization\Form\AuthorizationProfileForm->buildConditionsForm() (line 372 of modules/contrib/authorization/src/Form/AuthorizationProfileForm.php).
Notice: Undefined property: Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider::$revokeProviderProvisioned in Drupal\authorization\Form\AuthorizationProfileForm->buildConditionsForm() (line 387 of modules/contrib/authorization/src/Form/AuthorizationProfileForm.php).
Notice: Undefined property: Drupal\ldap_authorization\Plugin\authorization\provider\LDAPAuthorizationProvider::$regrantProviderProvisioned in Drupal\authorization\Form\AuthorizationProfileForm->buildConditionsForm() (line 393 of modules/contrib/authorization/src/Form/AuthorizationProfileForm.php).
CommentFileSizeAuthor
#2 2751729-2.patch1.89 KBwebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grahl created an issue. See original summary.

webflo’s picture

Status: Active » Needs review
FileSize
1.89 KB

The type hint on FormStateInterface is enough. The SubFormState is not different from FormStateInterface

Status: Needs review » Needs work

The last submitted patch, 2: 2751729-2.patch, failed testing.

The last submitted patch, 2: 2751729-2.patch, failed testing.

  • webflo committed 72451bf on 8.x-1.x
    Issue #2751729 by webflo: Fix form strict validation issues
    
webflo’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.