Problem/Motivation

Not following Drupal Code Standards

Proposed resolution

Run Coder module over SMTP module and fix all issues.

CommentFileSizeAuthor
#8 smtp-coding_standards-2751623-8-D7.patch2.28 KBSagar Ramgade
#2 code_standards-2751623-1.patch2.19 KBdavi.uezono
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davi.uezono created an issue. See original summary.

davi.uezono’s picture

davi.uezono CreditAttribution: davi.uezono at CI&T commented
FileSize
code_standards-2751623-1.patch2.19 KB

Fixed all issues in this version

davi.uezono’s picture

davi.uezono CreditAttribution: davi.uezono at CI&T commented
Status: Active » Needs work
davi.uezono’s picture

davi.uezono CreditAttribution: davi.uezono at CI&T commented
Status: Needs work » Needs review
davi.uezono’s picture

davi.uezono CreditAttribution: davi.uezono at CI&T commented
Assigned: davi.uezono » Unassigned
davi.uezono’s picture

davi.uezono CreditAttribution: davi.uezono at CI&T commented
Category: Task » Bug report
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Needs review » Needs work

Need re-roll

Sagar Ramgade’s picture

Sagar Ramgade CreditAttribution: Sagar Ramgade as a volunteer and at Trigyn Technologies Ltd commented
Status: Needs work » Needs review
FileSize
smtp-coding_standards-2751623-8-D7.patch2.28 KB

Patch re-rolled.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Assigned: Unassigned » renatog

In review.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Needs review » Reviewed & tested by the community

Hi!

I applied the patch and looks good for me.

+RTBC.

Regards.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Hello @wundo, how are u?

Patch #8 makes sense for you? If yes, Can you commit in the dev branch?

Thanks

  • wundo committed a05e229 on 7.x-1.x authored by Sagar Ramgade 
    Issue #2751623 by davi.uezono, Sagar Ramgade, wundo: Not following...
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Reviewed & tested by the community » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.