The toolbar is not responsive.
Steps to reproduce:
-----------------
Install Drupal Core
Pick either Seven or Bartik as your theme (it is broken in both)
Log in
Create a long piece of content
Click on the manage menu link once to open the second level of menu items
Drag your screen equal to below 671px (this is where it breaks)
Notice that when you scroll down on a long page you can no longer see the admin toolbar
Expected behavior:
----------------
I would expect the toolbar to stay at the top of the page like it does at 672px and above so that I can close the manage submenu
Bug:
----
Currently, if you have the manage menu open and have scrolled down you end up with a menu that you cannot close
More Info:
---------
Gifs and patch to come momentarily.
Comment | File | Size | Author |
---|---|---|---|
#6 | test.png | 29.21 KB | Chernous_dn |
#5 | 2751619-5-fix-toolbar-responsiveness.patch | 1.96 KB | ccjjmartin |
Comments
Comment #2
ccjjmartin CreditAttribution: ccjjmartin as a volunteer commentedShow problem gif:
---------------
Expected behavior gif:
-------------------
Comment #3
ccjjmartin CreditAttribution: ccjjmartin as a volunteer commentedComment #4
ccjjmartin CreditAttribution: ccjjmartin as a volunteer commentedComment #5
ccjjmartin CreditAttribution: ccjjmartin as a volunteer commentedI was reviewing my original patch and found that when switching position from "absolute" to "fixed" the z-index was not set correctly on larger screen sizes and content was appearing above the menu, this looked terrible. So I went back and added a higher z-index to the toolbar and it looks good to me now. I tested on El Capitan in Safari, Firefox, and Chrome. I took a look on Windows 7 and IE11 and this patch works over there too.
There is another bug in Windows 7 / IE11 related to something (probably JS) adding a large amount of padding to the body when you resize after having scrolled down. But, that issue exists before and after this patch so that will be fixed separately see issue #2751643: Body padding too large, displace calculation inconsistent (IE10, IE11, and iPad2)
Comment #6
Chernous_dn CreditAttribution: Chernous_dn at FFW for FFW commentedTest patch, work correctly. And on front page too.
Comment #7
Chernous_dn CreditAttribution: Chernous_dn at FFW for FFW commentedComment #8
Wim Leers#2: Nice! :)
I'm not sure whether this can still be changed. The point of Stable is that it's frozen. Assigning Cottser for commit.
Comment #9
star-szrBased on this CSS comment that's being updated I'm thinking this works as designed - minus the weird floating detached menu perhaps :D
I think the point is that on small screens real estate is often at a premium so the toolbar isn't fixed on smaller screens, "it scrolls with the page". #1847314-27: Reduce the dependency on JavaScript for the toolbar to display properly reinforces the code comment a bit.
I'm not sure what the toolbar did before #1847314: Reduce the dependency on JavaScript for the toolbar to display properly on small screens, might be worth a quick look, potentially we can find somewhere else this was discussed. But this doesn't feel like the kind of change to make without a fair amount of thought, particularly with Stable.
Comment #10
star-szrComment #11
ccjjmartin CreditAttribution: ccjjmartin as a volunteer commentedIf we passed the point of no return on the toolbar it might be worth looking into some other options for hiding the sidebar. The main thing I would consider a bug here is that when you scroll down on a long page you can't close the sidebar. The toolbar itself your right isn't really the problem here.
Maybe we could add something above "Content" that allows us to close the sidebar?
Comment #12
ccjjmartin CreditAttribution: ccjjmartin as a volunteer commentedComment #16
ccjjmartin CreditAttribution: ccjjmartin as a volunteer commentedSeems this is unlikely to gain traction due to it being a bug in stable. Marking as Closed (won't fix).