As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#5 interdiff.txt5.32 KBManjit.Singh
#5 Remove-@file-tag-docblock-2751177-5.patch11.31 KBManjit.Singh
#2 2751177-2.patch10.28 KBrajeshwari10
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rajeshwari10 created an issue. See original summary.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Status: Active » Needs review
FileSize
2751177-2.patch10.28 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2751177-2.patch, failed testing.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Status: Needs work » Needs review
Manjit.Singh’s picture

Manjit.Singh
Primary language Hindi
Location Chandigarh
CreditAttribution: Manjit.Singh at Srijan | A Material+ Company commented
Assigned: rajeshwari10 » Unassigned
FileSize
Remove-@file-tag-docblock-2751177-5.patch11.31 KB
interdiff.txt5.32 KB

Code looks good to me but i think there is some problem with the namespace path. I have done some changes in the patch file, let see what test bot thinks.

vbouchet’s picture

vbouchet
Location Toulouse
CreditAttribution: vbouchet at Acquia commented
Status: Needs review » Reviewed & tested by the community
Manjit.Singh’s picture

Manjit.Singh
Primary language Hindi
Location Chandigarh
CreditAttribution: Manjit.Singh at Srijan | A Material+ Company commented

Thanks a lot :)
Is there anything left ? Or we can commit this ?

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Reviewed & tested by the community » Needs work 
+++ b/modules/views_slideshow_cycle/src/Plugin/ViewsSlideshowType/Cycle.php
@@ -1,11 +1,6 @@
+namespace Drupal\views_slideshow_cycle\src\Plugin\ViewsSlideshowType;

+++ b/src/Annotation/ViewsSlideshowSkin.php
@@ -1,11 +1,6 @@
+namespace Drupal\views_slideshow\src\Annotation;

(etc)

the 'src' folder shouldn't be include in the namespace - see Drupal Namespace Standards.

  • NickWilde committed 505d42e on 8.x-4.x authored by rajeshwari10 
    Issue #2751177 by Manjit.Singh, rajeshwari10: Remove @file tag docblock...
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented

Applied the patch from #2, Thanks both of you for the patches.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Needs work » Fixed
rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Valuebound commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.