On form value suspicion preventing cache, show also the suspected value nested keys [#2750097]

Comment	File	Size	Author
#19	on_form_value_suspicion-2750097-19.patch	3.08 KB	znerol
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass
#12	authcache-show_value_nested_keys-2750097-12.patch	2.78 KB	hanoii
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass
#3	authcache-show_value_nested_keys-2750097-2.patch	1.17 KB	hanoii
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.4 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.5 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.6 & MySQL 5.5, D7 236 pass, 5 fail
#2	authcache-remove_members_only_widget-2750043-2.patch	7.22 KB	hanoii
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.4 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.5 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.6 & MySQL 5.5, D7 235 pass, 4 fail

Comment #1

16 June 2016 at 13:46

hanoii created an issue. See original summary.

Log in or register to post comments

Comment #2

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 16 June 2016 at 13:46

Status:

Active

» Needs review

File	Size
authcache-remove_members_only_widget-2750043-2.patch	7.22 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.4 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.5 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.6 & MySQL 5.5, D7 235 pass, 4 fail

Patch attached.

Log in or register to post comments

Comment #3

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 16 June 2016 at 13:47

File	Size
authcache-show_value_nested_keys-2750097-2.patch	1.17 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.4 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.5 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.6 & MySQL 5.5, D7 236 pass, 5 fail

1 file was hidden/shown/deleted

File	Size
authcache-remove_members_only_widget-2750043-2.patch	7.22 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.4 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.5 & MySQL 5.5, D7 235 pass, 4 fail PHP 5.6 & MySQL 5.5, D7 235 pass, 4 fail

oops, wrong patch, sorry.

Log in or register to post comments

Comment #4

16 June 2016 at 13:50

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

Log in or register to post comments

Comment #5

16 June 2016 at 13:50

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

Log in or register to post comments

Comment #6

16 June 2016 at 13:50

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

Log in or register to post comments

Comment #7

16 June 2016 at 13:50

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

Log in or register to post comments

Comment #8

16 June 2016 at 13:52

Status:

Needs review

» Needs work

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

Log in or register to post comments

Comment #9

16 June 2016 at 13:52

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

Log in or register to post comments

Comment #10

16 June 2016 at 13:52

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

Log in or register to post comments

Comment #11

16 June 2016 at 13:52

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

Log in or register to post comments

Comment #12

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 16 June 2016 at 14:00

File	Size
authcache-show_value_nested_keys-2750097-12.patch	2.78 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass

1 file was hidden/shown/deleted

File	Size
authcache-show_value_nested_keys-2750097-2.patch	1.17 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.4 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.5 & MySQL 5.5, D7 236 pass, 5 fail PHP 5.6 & MySQL 5.5, D7 236 pass, 5 fail

Fixing tests that seems to be realated to this, others looks unrelated.

Log in or register to post comments

Comment #13

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 16 June 2016 at 14:00

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #14

16 June 2016 at 14:08

Status:

Needs review

» Needs work

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

Log in or register to post comments

Comment #15

16 June 2016 at 14:08

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

Log in or register to post comments

Comment #16

16 June 2016 at 14:08

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

Log in or register to post comments

Comment #17

16 June 2016 at 14:09

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

Log in or register to post comments

Comment #18

znerol CreditAttribution: znerol commented 18 June 2016 at 16:31

This patch looks a lot like #2460953-20: Support Ajax Webforms. I will review both of them and try to understand the difference / the benefit of each.

Log in or register to post comments

Comment #19

znerol CreditAttribution: znerol commented 11 July 2016 at 06:05

Status:

Needs work

» Needs review

File	Size
on_form_value_suspicion-2750097-19.patch	3.08 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass

Let's use the same form as in Drupal core (see _form_builder_handle_input_element().

Log in or register to post comments

Comment #20

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 16 August 2016 at 14:15

For me it's fine, as long as it helps figuring out the element!

Log in or register to post comments

Comment #21

18 August 2016 at 21:35

znerol committed d702e74 on 7.x-2.x

Issue #2750097 by hanoii, znerol, firewaller: On form value suspicion...

Log in or register to post comments

Comment #22

znerol CreditAttribution: znerol commented 18 August 2016 at 21:36

Status:

Needs review

» Fixed

Thanks all for reporting the issue and helping with the patch.

Log in or register to post comments

Comment #23

1 September 2016 at 21:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

On form value suspicion preventing cache, show also the suspected value nested keys

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community