Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
We can reduce file I/O and calls to the 'identify' ImageMagick's binary by caching its results.
Proposed resolution
Integrate with the File Metadata Manager module, implement a plugin for the identify command results.
The patch below introduces a dependency to file_mdm
Remaining tasks
Review/feedback.
User interface changes
Several changes to the image toolkit settings' subform - to make it more readable given new addtions of caching options.
API changes
No changes to the methods called by image toolkit operations.
Some changes internal to the module, but I doubt there are out there classes extending imagemagick's classes.
Data model changes
Added some keys to the config schema, to allow capturing caching options.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2749283-8.patch | 67.34 KB | mondrake |
Comments
Comment #2
mondrakePatch.
Comment #4
mondrake#2 failed because the 'file_mdm' dependency is part of the patch, and in fact DrupalCI requires the dependency to be already set in the repo before adding dependent code :(
In any case, d.o. test are of very little relevance since most of the test code is bypassed when the ImageMagick's executable cannot be executed, which is the case of the test bots. Tests pass locally, though.
Comment #5
mondrakeChanges in this issue will be too big for version 1, my plan is to introduce a dependency to the File metadata manager module and Composer based dependency management.
Opened a 8.x-2.x branch where this could be managed better separately.
Comment #6
mondrakeComment #7
mondrakeReupload of patch in #2 without the additional dependency in .info.yml which have been applied in 8.x-2.x already.
Comment #8
mondrakeRerolled
Comment #10
mondrakeCommitted to 8.x-2.x