Hi,

Downloaded Module, Works great. There is issue with following with code standards. Please follow https://www.drupal.org/coding-standards
Reviewed Nodequeue 7.x-3.x dev module using coder module, Found some control statements and warning.

Here is the patch, which remove bugs, warnings and statements followed according to drupal standards.

CommentFileSizeAuthor
#3 nodequeue7.x-3.xdev_codecleanup-2748961-2.patch42.57 KBharish b
#2 Code review smartqueue _3.x.png96.93 KBharish b
#2 Code review nodequeue_generate_3.x.png94.1 KBharish b
#2 Code review nodequeue_3.x.png101.89 KBharish b
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

harish b created an issue. See original summary.

harish b’s picture

harish b CreditAttribution: harish b at Srijan | A Material+ Company for Srijan | A Material+ Company commented
FileSize
Code review nodequeue_3.x.png101.89 KB
Code review nodequeue_generate_3.x.png94.1 KB
Code review smartqueue _3.x.png96.93 KB
harish b’s picture

harish b CreditAttribution: harish b as a volunteer and at Srijan | A Material+ Company for Srijan | A Material+ Company commented
FileSize
nodequeue7.x-3.xdev_codecleanup-2748961-2.patch42.57 KB

Here is the patch, which remove bugs, warnings and statements followed according to drupal standards.

Please review it.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton as a volunteer and at Jeneration Web Development for BGP Site Solutions commented
Status: Needs review » Closed (outdated)

Since the 3.x branch is no longer active, I'm going to mark this issue as outdated. If any of these problems still exists for the 2.x branch, please reopen.