There seems to be some sort of regression with the issue credit UI on drupal.org. I am not sure exactly how to reproduce it but it appears that if a new person comments on an issue with an uploaded file (such that they would automatically get issue credit), they get assigned credit but everyone else loses credit.

At least I think that's what happening based on looking at the issue credits for these two issues:
https://www.drupal.org/node/2134259
https://www.drupal.org/node/728702

Currently Darren Oh is the only person credited on the first, and Crell is the only person credited on the second - even though there are other people who previously uploaded patches. It seems unlikely anyone removed all those issue credits from everyone else on purpose.

I believe I also saw this myself when uploading a screenshot to another issue, but I fixed the issue credits manually afterwards.

Comments

David_Rothstein created an issue. See original summary.

drumm’s picture

Assigned: Unassigned » drumm

I'll take a closer look at this later today.

Credit is only saved as a maintainer updates an issue, these are only the defaults. I don't think any credit is actually being "erased".

I think this happens when the last maintainer comment was before issue credits were launched, so there isn't actually credit saved yet for the issue.

  • drumm committed ff9cedc on 7.x-3.x
    Issue #2748147: Files uploaded before maintainers granted credit should...
drumm’s picture

Status: Active » Needs review
drumm’s picture

Status: Needs review » Fixed
Issue tags: +needs drupal.org deployment

I think this is looking okay on staging.

drumm’s picture

Issue tags: -needs drupal.org deployment

Now deployed.

Please update any issues like #728702: Visiting index.php should redirect to install.php if settings.php already has database credentials but database is empty. where the older files didn't get credited where credit is due.

David_Rothstein’s picture

Thanks! Good to know the credit is only being erased in some situations, not all of them.

I will update #728702: Visiting index.php should redirect to install.php if settings.php already has database credentials but database is empty. to add back the missing credits. I imagine there are some other issues that were affected as well, but it's something maintainers will tend to notice and fix when a patch is being committed and the issue gets marked as fixed.

David_Rothstein’s picture

Title: All previous issue credits are being erased when a patch is uploaded to an issue » All previous issue credits are being erased on some issues when a maintainer comments on it

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.