The modules that make up the "Panels Ecosystem" have not had new releases since February. Those modules are:

  • Panels
  • Panelizer
  • Page Manager
  • CTools

We rely on quite a bit of the committed but unreleased functionality in those modules. The purpose of this issue is to create and host mega patches that can be applied to the last release of each of the modules. The patches are essentially diffs between the module's last release and head.

These patches need to be hosted on D.O because the D.O packager will reject patches that live elsewhere when building the legacy tarball. See here for why we can't just reference a specific commit: http://lightning.acquia.com/blog/whats-up-700k-patch-to-panels

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

balsama created an issue. See original summary.

balsama’s picture

Panels patch. Beta4 to 4c4a3a7.

balsama’s picture

Page Manager Patch. Alpha23 to 09e79ff.

balsama’s picture

Issue summary: View changes
balsama’s picture

Panelizer patch. Alpha2 to 1ddfa61.

balsama’s picture

Status: Active » Needs review

These three seem to be working.

phenaproxima’s picture

CTools patch from 8.x-3.0-alpha26 tag to 058c6dfa.

phenaproxima’s picture

Updating the CTools patch with additional bugfixes (from 8.x-3.0-alpha26 to 0f3bcebe).

balsama’s picture

Status: Needs review » Fixed
balsama’s picture

Status: Fixed » Needs work
FileSize
6.04 KB

New patch for ctools.

balsama’s picture

Status: Needs work » Fixed
mpotter’s picture

We ran into a problem with the panels mega-patch. It is trying to delete a bunch of image files. But when using a newer version of patch (2.7.1) there are errors/warnings like this:

File images/arrow-active.png is not empty after patch; not deleting

for each binary file that was removed.

With an older version of patch (2.5.8) we don't get these errors/warnings.

The side-effect of this is that when doing a "composer update" when it tries to apply the patch with "patch -p1

Once these patches are committed to actual module releases this problem will go away, but would also be interested in knowing if there was a better way to create these patches that didn't cause these errors. Took several hours to track down why our Lightning build on one system was failing compared to another.

balsama’s picture

balsama’s picture

Status: Fixed » Needs work

Re: #12 what do you mean by "newer version of the patch" and the version numbers (2.7.1, 2.5.8), @mpotter? Sorry if I'm missing something obvious :) We only provide one patch for panels in this issue - and they aren't "versioned".

mpotter’s picture

What I mean is that if you are using v2.7.1 of the "patch" utility and you do:
patch -p1 <filename.patch
you get the errors like

File images/arrow-active.png is not empty after patch; not deleting

However, if you are using an older v2.5.8 of the "patch" utility you do not get those errors.

A bit more info...the patch process first tries to use "git apply". Using the panels mega-patch in #2, doing
git apply --check filename.patch
gives errors like this:

error: cannot apply binary patch to 'images/arrow-active.png' without full index line
error: images/arrow-active.png: patch does not apply

The failure of "git apply" is what causes it to try the "patch" command. And depending on your version of the patch command it will succeed or fail.

mpotter’s picture

Researching the git error a bit more, it appears that you need to create the patch file using the --binary option to fix this.

balsama’s picture

Recreated the panels patch (which, surprise, contains binary files) with the --binary option.

Dane Powell’s picture

#17 works for me and also fixes #2752735: Doc mentions removed session component

balsama’s picture

Status: Needs work » Fixed

Big +1 to mpotter for tracking this down. Tracking this over at #2752375: Cannot apply Panels patch now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

balsama’s picture

Status: Closed (fixed) » Needs work
FileSize
811.91 KB

New patch for panels.

balsama’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

RajabNatshah’s picture

I think we need this to work with panels 8.x-3.0-beta5
Playing around with the patch.

RajabNatshah’s picture

I had the updated patch in an issue under the panels project
#2810533: Advanced panels 8.x-3.x based on the work of Lightning profile

balsama’s picture

This patch brings layout_plugin from alpha22 to commit 96a5cf90 (which added the getLabel() method to LayoutBase)

phenaproxima’s picture

This brings Panelizer from 8.x-3.0-alpha2 to 54f0ac6e4f4ab2c30bf09d143554bb85576edf30.