The current Drupal 7 & 8 modules are using the 1.0-beta2 of the Yoast SEO JavaScript. We need to update both with the latest version of the Yoast SEO JavaScript(v.1.2.2)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ozin created an issue. See original summary.

ozin’s picture

Status: Active » Needs review
FileSize
235.45 KB

Updated js with the latest version. Patch attached. Please review.

robertragas’s picture

Hi Ozin, I tested the patch and works great! The new snipper editor is looking good.
It will be included in the next release which I try to do later today.

  • RobertRagas committed ba8350d on 7.x-1.x authored by ozin
    Issue #2747541 by ozin: Update js with the latest version of the...
robertragas’s picture

Status: Needs review » Fixed
ozin’s picture

Thanks!

robertragas’s picture

Status: Fixed » Needs work

Hmm , reopening it,
The snippet editor works, but I noticed now that it doesn't seem to pick up any of the word within the body field.

Does this works at you?

ozin’s picture

I will check it. Could you provide more details how it should use body field.

robertragas’s picture

Hello Ozin,

Standard with Yoast it uses the body field for analysis ( there is a patch coming up with multiple field support that your colleague made :) )

Also I checked out some more, and I see this is not the problem after all. The Snippet does take the correct text, the only thing that its missing is that there is no live reload.
In the last version when people fill in some text in the body the SEO score automatic gets updated, but in this one you need to save the node first, then edit it and you will see the correct score.

Do you need more information?

robertragas’s picture

Maybe it has to do with the added image where u deleted some code that rerenders the snippet from input.

ozin’s picture

Status: Needs work » Needs review
FileSize
240.84 KB

Hi @RobertRagas,

I've found some bugs with the title field and rating calculation as well. Please check my patch which should fix all those bugs.

ozin’s picture

FileSize
4.91 KB
robertragas’s picture

Thanks for the new patch ozin, I checked it again and this time everything seems to be working so accepting it and merging it in the branch.
There is 1 minor thing that I noticed. A score of 7 shows in the overview as "ok" with an orange dot, but in the node detail snippet it shows as "good" and green so wonder if we should change the yoast_seo_score_rating to make a 7 show as good.

  • RobertRagas committed 93ab718 on 7.x-1.x authored by ozin
    Issue #2747541 by ozin: Update js with the latest version of the...
ozin’s picture

Yes, the problem with the "seo_status" scheme type. There is the patch which fix field type.

  • RobertRagas committed ec57a98 on 7.x-1.x authored by ozin
    Issue #2747541 by ozin: Update js with the latest version of the...
robertragas’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.